[HIP] Correctly set HIP Kernel Buffer Arguments #970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veselypeta
force-pushed
the
petr/compiler-hip-kernels
branch
from
d76b521
to
05084a3
Compare
veselypeta
force-pushed
the
petr/compiler-hip-kernels
branch
3 times, most recently
from
c9b3493
to
76e9d4b
Compare
veselypeta
force-pushed
the
petr/compiler-hip-kernels
branch
3 times, most recently
from
469fb32
to
fb0d5b7
Compare
|
s/Compliation/Compilation/g |
veselypeta
changed the title
ldrumm
requested changes
Oct 19, 2023
veselypeta
force-pushed
the
petr/compiler-hip-kernels
branch
from
fb0d5b7
to
456ca02
Compare
pbalcer
reviewed
Oct 20, 2023
|
Closes #842 |
ldrumm
approved these changes
Oct 20, 2023
pbalcer
approved these changes
Oct 20, 2023
veselypeta
force-pushed
the
petr/compiler-hip-kernels
branch
3 times, most recently
from
6ee901b
to
a61c31f
Compare
veselypeta
force-pushed
the
petr/compiler-hip-kernels
branch
3 times, most recently
from
146bfc8
to
767b1fd
Compare
veselypeta
force-pushed
the
petr/compiler-hip-kernels
branch
from
2a83fd5
to
dfc5abe
Compare
pbalcer
approved these changes
Oct 24, 2023
|
@veselypeta Do you know the cause of the differences in accessor arguments between HIP and CUDA ? Thanks. |
|
Covered in #1030 |
This was referenced Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device binary code exported from SYCL produces different interfaces depending on the backend selected. On CUDA and L0 buffer arguments are encoded with two parameters 1) A pointer to the buffer 2) a sycl::id struct (the accessor). However, on HIP the accessor argument is encoded as three individual i64 arguments.
This PR correctly sets the kernel arguments for kernels compiled and run with the HIP backend.