[Bindless] Structs & enums for image types and cubemap enablement #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add structs/enums to distinguish between image types that can be represented equivalently in memory: - ur_exp_image_type_desc_t struct to hold the type of an image - ur_exp_image_type_t enum to enable distinguishing between image types that have the same underlying memory ordering/type Add structs/enums for cubemap sampling: - ur_exp_sampler_cubemap_properties_t struct to enable seamless filtering between cubemap faces - ur_exp_sampler_cubemap_filter_mode_t enum to enable distinguishing between cubemap seamless filtering options Co-authored-by: Sean Stirling <sean.stirling@codeplay.com> Co-authored-by: Isaac Ault <isaac.ault@codeplay.com> Co-authored-by: Przemek Malon <przemek.malon@codeplay.com>
Seanst98
force-pushed
the
sean/cubemaps
branch
from
15e7f03
to
4368c24
Compare
Seanst98
changed the title
isaacault
approved these changes
Oct 23, 2023
|
I have updated the target branch of this PR from the |
|
This work is outdated and will be replaced by a new PR for cubemaps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add structs/enums to distinguish between image types that can be represented equivalently in memory:
ur_exp_image_type_desc_tstruct to hold the type of an imageur_exp_image_type_tenum to enable distinguishing between image types that have the same underlying memory ordering/typeAdd structs/enums for cubemap sampling:
ur_exp_sampler_cubemap_properties_tstruct to enable seamless filtering between cubemap facesur_exp_sampler_cubemap_filter_mode_tenum to enable distinguishing between cubemap seamless filtering optionsThis should enable image arrays, cubemaps, and combined image types.