Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Clean up after conda init in cmake.yml #979

Merged

Conversation

lukaszstolarczuk
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk commented Oct 20, 2023

When initializing conda few extra commands are added to user's profile. These commands make it impossible to log in as the test user to the machine, since conda may be missing.

We can safely remove the whole '.profile' after the job.

@lukaszstolarczuk lukaszstolarczuk requested a review from a team as a code owner October 20, 2023 12:08
Copy link
Contributor

@kswiecicki kswiecicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you have a failing CI job https://github.com/oneapi-src/unified-runtime/actions/runs/6587485286/job/18077584172?pr=979. Probably needs just a re-run.

@lukaszstolarczuk
Copy link
Contributor Author

LGTM, but you have a failing CI job https://github.com/oneapi-src/unified-runtime/actions/runs/6587485286/job/18077584172?pr=979. Probably needs just a re-run.

It happened quite a few times on this PR, I suspect it may be caused by my changes 😉 I still need to investigate this.

When initializing conda few extra commands are added to user's profile.
These commands make it impossible to log in as the test user to the machine,
since conda may be missing.
We can safely remove the whole '.profile' after the job.
@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review November 7, 2023 09:54
@lukaszstolarczuk
Copy link
Contributor Author

Apparently remove-profiles parameter in conda-incubator/setup-miniconda action was doing more than its name suggested.
Also, if these profile files were not removed before conda init, then the initialization behavior was different.

Anyway, this fix should work just fine.

@lukaszstolarczuk lukaszstolarczuk merged commit 9fc8230 into oneapi-src:adapters Nov 15, 2023
48 checks passed
@lukaszstolarczuk lukaszstolarczuk deleted the fix-conda-workflow branch November 15, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants