Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIP] Implement ext_oneapi_queue_priority #984

Merged
merged 4 commits into from
Jan 5, 2024
Merged

[HIP] Implement ext_oneapi_queue_priority #984

merged 4 commits into from
Jan 5, 2024

Conversation

al42and
Copy link
Contributor

@al42and al42and commented Oct 21, 2023

No description provided.

@al42and al42and requested a review from a team as a code owner October 21, 2023 22:00
@al42and
Copy link
Contributor Author

al42and commented Oct 21, 2023

intel/llvm CI here intel/llvm#11622

@al42and al42and mentioned this pull request Oct 24, 2023
Merged
@al42and al42and force-pushed the ext_oneapi_queue_priority-hip branch from 95ad811 to f7d789d Compare October 31, 2023 14:26
mmoadeli
mmoadeli approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@mmoadeli mmoadeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@al42and
Copy link
Contributor Author

al42and commented Nov 8, 2023

Is there anything else left to do before this PR can get merged?

@kbenzie
Copy link
Contributor

kbenzie commented Nov 8, 2023

Is there anything else left to do before this PR can get merged?

I'll add the ready to merge label once the checks pass on the latest changes, then it'll be added to our merge queue. Once this is merged I'll request changes on intel/llvm#11622 to point at the merged commit and to integrate the changes over there.

@kbenzie
Copy link
Contributor

kbenzie commented Nov 9, 2023

Having some CI issues, I'll come back to this and retry the jobs once we've cleared the job backlog.

@kbenzie kbenzie added the ready to merge Added to PR's which are ready to merge label Nov 10, 2023
@fabiomestre fabiomestre changed the base branch from adapters to main December 5, 2023 16:53
@fabiomestre
Copy link
Contributor

I have updated the target branch of this PR from the adapters branch to the main branch.
Development in UR is moving back to main. The adapters branch will soon be deleted.

@al42and
Copy link
Contributor Author

al42and commented Dec 5, 2023

Thanks, @fabiomestre. Any actions needed from me?

@kbenzie kbenzie merged commit 46a886d into oneapi-src:main Jan 5, 2024
@kbenzie kbenzie mentioned this pull request Jan 5, 2024
Merged
@kbenzie
Copy link
Contributor

kbenzie commented Jan 5, 2024

Unforutately this has caused a regression on main so reverting, will aim to fix that up and get it merged soon.

@al42and
Copy link
Contributor Author

al42and commented Jan 7, 2024

@kbenzie: Yeah, this change has rotten a bit :(
I'll make suggestions to #1229 with the necessary fixes.

@al42and al42and deleted the ext_oneapi_queue_priority-hip branch January 31, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmoadeli mmoadeli mmoadeli approved these changes

Assignees
No one assigned
Labels
ready to merge Added to PR's which are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@al42and @kbenzie @fabiomestre @mmoadeli