Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPEC] Clarify the BinaryType output of urProgramCreateWithBinary #991

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions include/ur_api.h
Original file line number Diff line number Diff line change
Expand Up @@ -4011,6 +4011,9 @@ urProgramCreateWithIL(
///
/// @details
/// - The application may call this function from simultaneous threads.
/// - Following a successful call to this entry point, `phProgram` will
/// contain a binary of type ::UR_PROGRAM_BINARY_TYPE_COMPILED_OBJECT or
/// ::UR_PROGRAM_BINARY_TYPE_LIBRARY for `hDevice`.
///
/// @remarks
/// _Analogues_
Expand Down
1 change: 1 addition & 0 deletions scripts/core/program.yml
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ analogue:
- "**clCreateProgramWithBinary**"
details:
- "The application may call this function from simultaneous threads."
- "Following a successful call to this entry point, `phProgram` will contain a binary of type $X_PROGRAM_BINARY_TYPE_COMPILED_OBJECT or $X_PROGRAM_BINARY_TYPE_LIBRARY for `hDevice`."
params:
- type: $x_context_handle_t
name: hContext
Expand Down
3 changes: 3 additions & 0 deletions source/loader/ur_libapi.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2882,6 +2882,9 @@ ur_result_t UR_APICALL urProgramCreateWithIL(
///
/// @details
/// - The application may call this function from simultaneous threads.
/// - Following a successful call to this entry point, `phProgram` will
/// contain a binary of type ::UR_PROGRAM_BINARY_TYPE_COMPILED_OBJECT or
/// ::UR_PROGRAM_BINARY_TYPE_LIBRARY for `hDevice`.
///
/// @remarks
/// _Analogues_
Expand Down
3 changes: 3 additions & 0 deletions source/ur_api.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2447,6 +2447,9 @@ ur_result_t UR_APICALL urProgramCreateWithIL(
///
/// @details
/// - The application may call this function from simultaneous threads.
/// - Following a successful call to this entry point, `phProgram` will
/// contain a binary of type ::UR_PROGRAM_BINARY_TYPE_COMPILED_OBJECT or
/// ::UR_PROGRAM_BINARY_TYPE_LIBRARY for `hDevice`.
///
/// @remarks
/// _Analogues_
Expand Down