Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming for Stats methods and members #56

Merged
merged 6 commits into from
Dec 5, 2023

Conversation

jeremyfowers
Copy link
Collaborator

Closes #26 by adopting the suggested naming scheme across the codebase.

Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
@jeremyfowers jeremyfowers self-assigned this Dec 4, 2023
@jeremyfowers jeremyfowers removed the request for review from ramkrishna2910 December 4, 2023 21:24
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
@jeremyfowers jeremyfowers marked this pull request as ready for review December 4, 2023 21:49
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Copy link
Collaborator

@danielholanda danielholanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing version update? Not as critical as this will be bundled with other breaking changes.

@jeremyfowers jeremyfowers enabled auto-merge (squash) December 5, 2023 01:07
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
@jeremyfowers jeremyfowers merged commit f8f8093 into canary Dec 5, 2023
10 checks passed
@jeremyfowers jeremyfowers deleted the 26-clarify-naming-for-builds-and-evaluations branch December 5, 2023 14:36
jeremyfowers added a commit that referenced this pull request Dec 6, 2023
Signed-off-by: Jeremy Fowers <jeremy.fowers@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants