Eth 2.0 Production #109
Closed
Eth 2.0 Production #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronKutch
commented
Oct 28, 2022
| // get this first in case inbetween the calls is a block boundary | ||
| // don't accidentally use this variable elswhere | ||
| let unsafe_latest_block = get_latest_block_number_with_retry(web3).await; | ||
|
|
There was a problem hiding this comment.
I moved this upwards because there could be a spurious race condition where a new block is produced or finalized in the middle, this order won't cause spurious failures I don't think
|
The automated release is failing probably because of cross-rs/cross#724, it appears like we should add |
|
going to make the fixes on main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is identical to
mainexcept for constant changes to use finalization that we couldn't test with integration tests, and a single line movement