Fix the override of the Image objectPosition attribute #521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While experimenting with this great template, I noticed that when passing an
objectPosition
attribute to the image in theHero2
component, the property is overridden by its default value (center
) at line 119 in theimages-optimization.ts
file.Issue details
objectPosition
prop in not passed to thegetStyle
function, causing it to default tocenter
instead of using the provided value.images-optimization.ts
getStyle
Fix
objectPosition
from the props and passed it thegetStyle
function.Impact
objectPosition
attribute works as expected when used in components likeHero2
.I hope this PR is helpful! Let me know if any further adjustments are needed :)