-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing collapsible tables for mobile views #405
Open
thepigeonoftime
wants to merge
1
commit into
ooni:master
Choose a base branch
from
thepigeonoftime:responsive-tables
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarathms
modified the milestones:
Sprint 27 - Hexacorallia,
Sprint 28 - Corallimorpharia
Dec 7, 2020
sarathms
modified the milestones:
Sprint 28 - Corallimorpharia,
Sprint 29 - Dogfish shark
Dec 21, 2020
sarathms
modified the milestones:
Sprint 32 - Tursiops truncatus,
Sprint 33 - Actinia equina
Feb 17, 2021
hellais
modified the milestones:
Sprint 37 - Vampire squid,
Sprint 38 - Umbrella octopus
Apr 26, 2021
sarathms
modified the milestones:
Sprint 43 - Confused Kraken,
Sprint 44 - Dancing Sirens
Jul 20, 2021
sarathms
modified the milestones:
Sprint 44 - Dancing Sirens,
Sprint 45 - Antarctic Krill
Aug 2, 2021
bassosimone
modified the milestones:
Sprint 45 - Antarctic Krill,
Sprint 46 - Happy Oyster
Aug 16, 2021
sarathms
modified the milestones:
Sprint 46 - Happy Oyster,
Sprint 47 - Caribbean Reef Octopus
Aug 30, 2021
sarathms
modified the milestones:
Sprint 47 - Caribbean Reef Octopus,
Sprint 48 - Amazon river dolphin
Sep 13, 2021
sarathms
modified the milestones:
Sprint 48 - Amazon river dolphin,
Sprint 49 - Humpback whale
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant as a test branch for collapsible (column to rows) tables for mobile views, it works through a Javascript that adds table header captions as attributes into corresponding
<td>
tags which are then prepended using CSS. When Javascript is disabled it falls back to scrollbars where tables overflow.Things to consider:
<table>
tags. If this is not intended it would be required to add an identifier class to the tables this should apply to and adjust the topmost querySelector in the script to it.<td>
's seem to be used for annotation, e.g.This site is likely blocked because it can also be used as a censorship circumvention tool by acting as a web proxy.
at https://ooni.org/post/indonesia-internet-censorship/ , this would be wrongly displayed as its own table using the current approach (but could be circumvented by giving those<td>
's a special class)