Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing collapsible tables for mobile views #405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thepigeonoftime
Copy link
Contributor

This is meant as a test branch for collapsible (column to rows) tables for mobile views, it works through a Javascript that adds table header captions as attributes into corresponding <td> tags which are then prepended using CSS. When Javascript is disabled it falls back to scrollbars where tables overflow.

Things to consider:

  • This currently applies to all <table> tags. If this is not intended it would be required to add an identifier class to the tables this should apply to and adjust the topmost querySelector in the script to it.
  • Occasionally <td>'s seem to be used for annotation, e.g. This site is likely blocked because it can also be used as a censorship circumvention tool by acting as a web proxy. at https://ooni.org/post/indonesia-internet-censorship/ , this would be wrongly displayed as its own table using the current approach (but could be circumvented by giving those <td>'s a special class)
  • The CSS markup for the collapsed tables might require some tweaking to fit into the overall design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants