Feat: Add News Media Scan flavor
#549
Conversation
There was a problem hiding this comment.
I am fine with merging this code into the master branch already under the argument that it's easier to keep things in sync if we have this code in tree.
In this review, I have tried to think about everything that we should clearly define for us to keep this app in sync with out mainline app. So, I think the focus of the discussion should not be much the code you're adding here, which is fine, but rather how we're planning on maintaining it. We can have this discussion as part of merging or we can create an issue describing the aspects we need to discuss in greater detail, depending on what's more convenient to you.
🐳
app/build.gradle
Outdated
| applicationId 'com.dw.ooniprobe' | ||
| resValue "string", "APP_NAME", "DW Media Probe" | ||
| buildConfigField 'String', 'BASE_SOFTWARE_NAME', '"dw-media-probe-android"' | ||
| versionName '0.0.1' |
There was a problem hiding this comment.
In terms of maintainability, we should figure out before hand a way to map the dw-flavoured-app version to the actual ooniprobe-android version. The simplest scheme that comes to mind is that of using the same version number and the same version code we use for ooniprobe-android. Because using the same version number may be odd (would it be odd?), perhaps we can just share the version code? What do you think?
| @@ -0,0 +1,43 @@ | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | |||
| xmlns:tools="http://schemas.android.com/tools"> | |||
There was a problem hiding this comment.
Did you test whether it's possible to install the dw-flavoured-app and ooniprobe side by side? As far as I know, it is currently not possible to install OONI Probe stable and OONI Probe experimental side by side. While that may be acceptable because it's only us who install the experimental app, not allowing installation side by side will be a bit more confusing for people. That said, also allowing installing side-by-side is weird because we are going to have tow ~ooniprobe apps competing for collecting measurements. Did you spend time thinking about which would be the best way to handle this side by side scenario?
| @@ -0,0 +1,404 @@ | |||
| <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
My understanding is that this file completely duplicates the ooniprobe preferences. I think we should start thinking about a way to be sure we always sync up preferences changes. Did you already start to think about this? What do you think is the best strategy to ensure this happens?
| @@ -0,0 +1,30 @@ | |||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
I assume this logo is there because we want to say something like "powered by", right?
|
Issues reported on slack:
|
|
## Proposed Changes - Define `flavorDimensions` for `provider` where specific resources for `ooni` or `dw` can be placed. - Provide base strings in the main resources `English` where more languages can be added in the provider folders and supported languages added. - Move `ooni` specific translations to the right folder. --------- Co-authored-by: Simone Basso <bassosimone@gmail.com>
aanorbel
changed the title
News Media Scan flavor
Proposed Changes
Tasks