Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Dashboard glitch #612

Merged
merged 8 commits into from
Dec 5, 2023
Merged

Fix: Dashboard glitch #612

merged 8 commits into from
Dec 5, 2023

Conversation

aanorbel
Copy link
Member

Proposed Changes

  • Replace HeterogeneousRecyclerAdapter with RecyclerView.Adapter
  • Add a ViewModel for state management

Base automatically changed from chore/dashboard-fragment-upgrade-to-view-binding to master September 11, 2023 07:55
@aanorbel aanorbel marked this pull request as draft October 18, 2023 11:38
@aanorbel aanorbel marked this pull request as ready for review October 31, 2023 17:06
@aanorbel
Copy link
Member Author

ResultTest#getLastResult is unstable. Investigate and fix later.

bassosimone
bassosimone approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@aanorbel aanorbel merged commit 87e854c into master Dec 5, 2023
4 of 5 checks passed
@aanorbel aanorbel deleted the fix/dashboard-glitch branch December 5, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

@hellais hellais Awaiting requested review from hellais

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aanorbel @bassosimone