chore: use probe-cli v3.19.0 #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aanorbel it's 3.19.0-alpha |
aanorbel
changed the title
…ved from the `CLI`
This was
linked to
issues
Oct 16, 2023
Fixes ooni/probe#2561 ## Proposed Changes - Update support for socks proxy to use dropdown for selecting a scheme. - Update code to save and retrieve the various proxies. 
bassosimone
suggested changes
Oct 20, 2023
| if (pm == null || pm.isTestRiseupVPN()) | ||
| list.add(new RiseupVPN());*/ | ||
| if (pm == null || pm.isTestRiseupVPN()) | ||
| list.add(new RiseupVPN()); |
There was a problem hiding this comment.
We should run RiseupVPN inside the experimental suite. If this change requires too much churn, I would recommend enabling it in the next release, but it must not run as part of circumvention.
There was a problem hiding this comment.
Started a PR to effect this #625 .
We would need to test properly and merge before the next release
aanorbel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ooni/probe#2524
Proposed Changes
echcheckmobile: add echcheck experiment probe#2567.