Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Designs] Implement add link flow #642
[New Designs] Implement add link flow #642
Changes from 48 commits
f1392aa
5ac4479
4d0a80d
631230a
1f813af
9b41077
059ef51
66ffbc3
09d2685
9353e64
657a6c9
6fd4edf
d532158
9e4ea1d
9bbe78d
d1c53cd
de8667b
1c9db05
c4d1e68
9309eff
51f350e
1461e29
1c5a84a
20a3160
5fbc024
3902641
2044002
30d799b
8c1ab25
2d4437d
c2376ec
4b51010
1b0a716
c5a2db4
31f8d4c
80731aa
b39b639
c51ebb0
d2dd31b
369adfa
1b254ee
599fe32
b13c5a0
b7b4536
d9ca5df
e1b15b8
4e0d850
44b4ac5
aa702c5
86342f1
d3bd5d7
5a42afb
44ea86d
dad3f90
788d22a
b439010
d5c8531
db37b06
ae929c8
8375440
5feeaab
bd68a91
d096681
1b2ac66
4bf6085
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, do not use
_
for package names. It seems to be against some Java coding style conventions set forth by Oracle and Google, as documented at https://stackoverflow.com/a/3179221.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe split this long block of code by adding blank lines and brief comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should configure the kotlin editor to add an empty line at EOF.