编辑评论 UI & 番剧评论 #634
Merged
编辑评论 UI & 番剧评论 #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Him188
reviewed
Jul 24, 2024
There was a problem hiding this comment.
我比较关注交互最小大小 (48dp) 问题, 直接在这里讨论吧, 我就不在每一行上面发一个 review 了.
我个人是比较赞成这个交互大小限制的. 哔哩哔哩的按钮虽然看起来小, 但它实际上有隐藏的交互高度 (空白区域是可以点击的), 所以它评论的赞也不是那么难点击 (虽然还是太小)
如果不是非常有必要, 我不赞成调小交互体积.
编辑评论的 actions 用默认 48.dp 高度如果会很丑的话, 能不能通过增大编辑框大小 (which 实际上是你刻意调小的), 来解决?
展示的评论里的这一行, 改成不要有 spacedBy, 用 IconButton 默认大小的情况下, 只把里面的 icon 变小来达到视觉上变小的效果, 会不会更好?
app/shared/src/commonMain/kotlin/ui/subject/components/comment/Comment.kt
Outdated
Show resolved
Hide resolved
app/shared/src/commonMain/kotlin/ui/subject/components/comment/Comment.kt
Outdated
Show resolved
Hide resolved
app/shared/src/commonMain/kotlin/ui/subject/components/comment/Comment.kt
Outdated
Show resolved
Hide resolved
app/shared/src/commonMain/kotlin/ui/subject/components/comment/Comment.kt
Outdated
Show resolved
Hide resolved
app/shared/src/commonMain/kotlin/ui/subject/components/comment/Comment.kt
Outdated
Show resolved
Hide resolved
app/shared/src/commonMain/kotlin/ui/subject/episode/comments/EpisodeCommentColumn.kt
Outdated
Show resolved
Hide resolved
app/shared/src/commonMain/kotlin/ui/subject/episode/comments/EpisodeCommentColumn.kt
Outdated
Show resolved
Hide resolved
app/shared/src/commonMain/kotlin/ui/subject/episode/comments/EpisodeEditCommentSheet.kt
Outdated
Show resolved
Hide resolved
app/shared/src/commonMain/kotlin/ui/subject/episode/comments/EpisodeEditCommentSheet.kt
Outdated
Show resolved
Hide resolved
app/shared/src/commonMain/kotlin/ui/subject/episode/comments/EpisodeEditCommentSheet.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # app/shared/src/commonMain/kotlin/ui/subject/episode/EpisodePage.kt
Him188
reviewed
Jul 26, 2024
app/shared/src/commonMain/kotlin/ui/subject/components/comment/EditComment.kt
Outdated
Show resolved
Hide resolved
app/shared/src/commonMain/kotlin/ui/subject/components/comment/EditComment.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # app/shared/src/androidMain/kotlin/ui/subject/episode/comments/CommentColumn.android.kt # app/shared/src/commonMain/kotlin/ui/subject/components/comment/Comment.kt
|
这个分支 luckily 居然没有任何一行 conflict |
|
现在还有点问题：
|
不能，这逻辑都冲突了 |
那就写自定义layout了 |
Him188
reviewed
Aug 13, 2024
app/shared/src/commonMain/kotlin/ui/subject/components/comment/EditCommentDefaults.kt
Outdated
Show resolved
Hide resolved
app/shared/src/commonMain/kotlin/ui/subject/components/comment/CommentEditorPreviewerState.kt
Outdated
Show resolved
Hide resolved
app/shared/src/commonMain/kotlin/data/repository/CommentRepository.kt
Outdated
Show resolved
Hide resolved
|
18 conversations must be resolved before merging. |
Him188
reviewed
Aug 14, 2024
Him188
approved these changes
Aug 14, 2024
app/shared/src/androidMain/kotlin/ui/foundation/widgets/ModalBottomImeAwareSheet.android.kt
Show resolved
Hide resolved
Him188
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在视频中展示了所有已经做好的功能
S40724-23253756-1.mp4
未完成的功能：