Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

使用滑动手势时显示时间 #707

Merged
merged 3 commits into from
Aug 7, 2024
Merged

使用滑动手势时显示时间 #707

merged 3 commits into from
Aug 7, 2024

Conversation

NieR4ever
Copy link
Member

resolve #701

@NieR4ever
Copy link
Member Author

Snipaste_2024-08-05_23-44-30 Snipaste_2024-08-05_23-45-02

Him188
Him188 reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以把 vertical padding 弄小点

@NieR4ever
Copy link
Member Author

Snipaste_2024-08-06_06-58-21 Snipaste_2024-08-06_06-58-59

@NieR4ever NieR4ever requested a review from Him188 August 5, 2024 23:02
@Him188
Copy link
Member

Him188 commented Aug 6, 2024

我感觉还是比较大，可以不要？

Cc @StageGuard

@StageGuard
Copy link
Member

StageGuard commented Aug 6, 2024 •
edited
Loading

我感觉还是比较大，可以不要？

Cc @StageGuard

我觉得这个还是有必要的，不在全屏下可以缩小 vertical padding

Him188
Him188 reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

等把高度改好后再 request 一下我

app/shared/video-player/src/commonMain/kotlin/ui/progress/MediaProgressSlider.kt Outdated Show resolved Hide resolved
app/shared/video-player/src/commonMain/kotlin/ui/progress/MediaProgressSlider.kt Outdated Show resolved Hide resolved
app/shared/video-player/src/commonMain/kotlin/ui/progress/MediaProgressSlider.kt Outdated Show resolved Hide resolved
app/shared/video-player/src/commonMain/kotlin/ui/progress/MediaProgressSlider.kt Outdated Show resolved Hide resolved
app/shared/video-player/src/commonMain/kotlin/ui/progress/MediaProgressSlider.kt Outdated Show resolved Hide resolved
@NieR4ever
Copy link
Member Author

Snipaste_2024-08-06_14-25-59 Snipaste_2024-08-06_14-26-30

@NieR4ever NieR4ever requested a review from Him188 August 6, 2024 07:14
@Him188
Copy link
Member

Him188 commented Aug 6, 2024

新版不错

Him188
Him188 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@Him188 Him188 requested a review from StageGuard August 6, 2024 20:05
@Him188
Copy link
Member

Him188 commented Aug 6, 2024

可以 merge,
@StageGuard 你想 review 吗

@Him188 Him188 modified the milestones: 3.7.0, 3.6.0 Aug 6, 2024
@NieR4ever
Copy link
Member Author

NieR4ever commented Aug 7, 2024 •
edited
Loading

现在安卓端使用滑动手势时使用第二根手指触摸进度条会出现第二个 preview time text，这是由于当时做 #573 实现的功能，现在可以用显示在 thumb 上的 preview time text 替代 #573 中安卓实现的部分，即仅在拖拽进度条时显示 preview time text on thumb 而非触摸

会被 #585 影响，现在可能还做不了

@Him188 Him188 mentioned this pull request Aug 7, 2024
Closed
@Him188
Copy link
Member

Him188 commented Aug 7, 2024

普通级别bug，不用着急修

@Him188 Him188 merged commit bd540d3 into master Aug 7, 2024
8 checks passed
@Him188 Him188 deleted the NieR/display-time-on-detached-slider branch August 7, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Him188 Him188 Him188 approved these changes

@StageGuard StageGuard StageGuard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

使用滑动手势时显示时间
3 participants
@NieR4ever @Him188 @StageGuard