Casting of arrays into specified Schemas #615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbuhot
reviewed
Jul 7, 2024
| @@ -207,6 +207,10 @@ defmodule OpenApiSpex.Cast do | |||
| def cast(%__MODULE__{schema: %{type: _other}} = ctx), | |||
| do: error(ctx, {:invalid_schema_type}) | |||
|
|
|||
| def cast(%__MODULE__{value: struct, schema: schema_module} = ctx) | |||
| when is_struct(struct) and is_atom(schema_module), | |||
| do: cast(ctx.schema.schema(), ctx.value) | |||
There was a problem hiding this comment.
We avoid calling the schema() function like this during casting as it can have performance impacts.
The full API schema should be resolved before casting using OpenApiSpex.resolve_schema_modules
Once resolved, the schema_module will be replaced by a %Reference{} struct which will be handled by an earlier clause.
mbuhot
reviewed
Jul 7, 2024
| type: :object, | ||
| properties: %{ | ||
| email: %Schema{type: :string}, | ||
| permissions: %Schema{type: :array, items: PermissionSchema} |
There was a problem hiding this comment.
items should be an explicit %Reference{}, or use OpenApiSpex.resolve_schema_modules to convert it to one automatically.
|
Closing this one. If you're still experiencing errors after applying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello dear maintainers!
I'm having errors when converting a structure with a list of substructures, like this:
That's why I made this fix with a test that reproduces a similar situation.
It would be great if you could accept a PR or give me some tips on how to use the library correctly (if I'm doing something wrong)