Fix cast x-validate when decoded schema #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorbash
reviewed
Dec 16, 2024
lib/open_api_spex/cast.ex
Outdated
| do: module.cast(ctx) | ||
|
|
||
| def cast(%__MODULE__{schema: %{"x-validate": module}} = ctx) when is_binary(module), | ||
| do: module |> Elixir.String.split(".") |> Module.concat() |> apply(:cast, [ctx]) |
There was a problem hiding this comment.
Let's fix this warning, otherwise LGTM.
There was a problem hiding this comment.
@zorbash pinging you case you don't get the workflow approval notification :)
zorbash
approved these changes
Dec 16, 2024
This was referenced Dec 17, 2024
nathanalderson
pushed a commit
to Tango-Tango/open_api_spex
that referenced
this pull request
Dec 20, 2024
* Fix cast x-validate when decoded schema * fix credo complain when using apply/3 --------- Co-authored-by: Giorgio Torres <giorgio.torres@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #646