Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image tag in GPU/TPU resource usage collect addon #21

Conversation

z1ens
Copy link
Contributor

@z1ens z1ens commented Aug 28, 2024

Update 28.08

  • Fix the hard-coded image tag in addon-template.yaml, Makefile and kustomization.yaml

@qiujian16
Copy link
Member

need a rebase

…ach managed clusters, develop the add-on in addontemplate mode, fix image tag.

Signed-off-by: Zhe Shen <xxtale02591@gmail.com>
@haoqing0110
Copy link
Member

/lgtm
/approve

@qiujian16
Copy link
Member

/approve
@haoqing0110 would you add owner file under this use-collector dir so you and z1en could tag the pr.

Copy link

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, qiujian16, z1ens

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit afa59f3 into open-cluster-management-io:main Aug 29, 2024
1 of 2 checks passed
@z1ens z1ens deleted the gpu-tpu-addon-template branch September 2, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants