-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure content according to methodology #317
Restructure content according to methodology #317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rename the
content
directory tochapters
. - Restructure the drill directory as we discussed:
content/software-stack/system-calls/drills/
|-- basic-syscall/
| |-- README.md
| |-- support/
| `-- solution/
|-- libc-syscall/
| |-- README.md
| `-- support/
`-- syscall-wrapper/
|-- README.md
|-- support/
`-- solution/
@gabrielmocanu, I applied your comments. See the last two commits. |
@razvand add the Makefile and build files from the |
@teodutu this currently does not follow the structure stated in the methodology |
Yup, but at least it's closer. Restructuring the repo according to the updated methodology is probably an unrealistic goal until tomorrow. |
Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>
Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>
Signed-off-by: Razvan Deaconescu <razvan.deaconescu@upb.ro>
70ee8ad
to
a7e5cd2
Compare
Move the remaining media files into their subchapters according to the restructuring. Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
The new structure of the repo means that media paths will differ between the stored and rendered slides, but MarkdownPP cannot make modifications to links to such files. This commit introduces a custom preprocessor that handles `!INCLUDE`s as well as changing the links to fit the path where the slides are build. Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
It is useful for testing changes made to `config.yml` or written content files locally. Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
@teodutu, @gabrielmocanu the rendered version link [1] does not work. [1] http://open-education-hub.github.io/operating-systems/317/ |
Render it again. Probably another PR was merged. |
@teodutu , I'll check this later today, so we can integrate it. |
…he methodology Update `config.yml` and the content folders to render the website according to the new methodology. Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
a4bf51c
to
3ccf924
Compare
I finally fixed the errors. @razvand @Alex-deVis take a look at the restructured Software Stack chapter [1] and see if you like it. [1] https://open-education-hub.github.io/operating-systems/317/Software%20Stack/ |
@teodutu, I think it would be better to put the I find it more intuitive for Also, even if it is repetitive, I think it is a good idea to keep the Assignments page as it helps to find projects quickly. These points aside, everything looks good and we should merge it ASAP. We can make changes based on live feedback in the following weeks. |
@Alex-deVis I think the subchapters need to be split into another category such that the sidebar looks like this:
How to name "That other category"? |
On second thought, I think we should stick to the methodology and nest |
IMO the idea of a project is something tied to the chapter as a whole (in this case to |
Whatever gets this merged faster. |
…ining a single question This fits the methodology according to which there should be one only one question per file. Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
26dc177
to
fa6eee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
… action PR open-education-hub#317 restructured the repository. A part of its changes meant removing the `chapters` directory. This commit fixes open-education-hub#340 by removing mentions to it from the `README.md` and from the labeler action. Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
Updated comment to reflect actual content in code. Signed-off-by: Tache Robert Andrei <tacheandu@gmail.com> Propagate changes to the repo's layout to the `README.md` and labeler action PR open-education-hub#317 restructured the repository. A part of its changes meant removing the `chapters` directory. This commit fixes open-education-hub#340 by removing mentions to it from the `README.md` and from the labeler action. Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
… action PR open-education-hub#317 restructured the repository. A part of its changes meant removing the `chapters` directory. This commit fixes open-education-hub#340 by removing mentions to it from the `README.md` and from the labeler action. Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
… action PR open-education-hub#317 restructured the repository. A part of its changes meant removing the `chapters` directory. This commit fixes open-education-hub#340 by removing mentions to it from the `README.md` and from the labeler action. Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
Restructure repository according to Open Education Hub Methodology.