Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add evaluation details to finally hook stage #328

Open
toddbaert opened this issue Dec 11, 2024 · 0 comments · May be fixed by #335
Open

Add evaluation details to finally hook stage #328

toddbaert opened this issue Dec 11, 2024 · 0 comments · May be fixed by #335
Assignees
@askpt

Comments

@toddbaert
Copy link
Member

Add evaluation details to finally hook stage.

Notes

This breaks the signature of the finally stages based on this spec enhancement. It is not considered a breaking change to the SDK because hooks are marked as experimental in the spec, and the change has no impact on known hooks.

- finally(hookContext, hookHints)
+finally(hookContext, evaluationDetails, hookHints)

Acceptance criteria:

  • finally hook stage modified
  • associated tests

Follow ups:

  • update contribs
@askpt askpt self-assigned this Dec 20, 2024
@askpt askpt linked a pull request Dec 20, 2024 that will close this issue
Open
@askpt askpt linked a pull request Dec 20, 2024 that will close this issue
feat: Add evaluation details to finally hook stage #335
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@askpt askpt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add evaluation details to finally hook stage open-feature/dotnet-sdk
2 participants
@askpt @toddbaert