feat: Add evaluation details to finally hook stage #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
==========================================
- Coverage 85.30% 85.27% -0.04%
==========================================
Files 36 36
Lines 1477 1480 +3
Branches 150 151 +1
==========================================
+ Hits 1260 1262 +2
Misses 187 187
- Partials 30 31 +1 ☔ View full report in Codecov by Sentry. |
beeme1mr
reviewed
Dec 20, 2024
src/OpenFeature/OpenFeatureClient.cs
Outdated
| throw new ProviderNotReadyException("Provider has not yet completed initialization."); | ||
| } | ||
| else if (provider.Status == ProviderStatus.Fatal) | ||
| { | ||
| evaluation = new FlagEvaluationDetails<T>(flagKey, defaultValue, ErrorType.ProviderFatal, Reason.Error, string.Empty, string.Empty); |
There was a problem hiding this comment.
Won't this be overridden in the catch block?
There was a problem hiding this comment.
You are right! Removed here: 5cedb62
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
beeme1mr
reviewed
Dec 20, 2024
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
beeme1mr
approved these changes
Dec 20, 2024
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
chrfwow
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add evaluation details to the finally hook stage
This pull request includes several changes to improve the handling of flag evaluation details and error handling in the OpenFeature library. The most important changes include modifying hook methods to accept
FlagEvaluationDetailsas a parameter, updating theEvaluateFlagAsyncmethod to handle provider errors more gracefully, and adjusting the corresponding unit tests to reflect these changes.Related Issues
Fixes #328
Notes
Improvements to Hook Methods:
src/OpenFeature/Hook.cs: Modified theFinallyAsyncmethods to acceptFlagEvaluationDetailsas a parameter. [1]src/OpenFeature/Hook.cs: Modified the hooks methods to split the parameters per line.[1] [2] [3]Enhancements to Flag Evaluation:
src/OpenFeature/OpenFeatureClient.cs: Updated theEvaluateFlagAsyncmethod to initializeFlagEvaluationDetailsin case of provider errors and ensure theFinallyAsynchook is always called with the correct evaluation details. [1] [2] [3]