Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README.md #155

Merged
merged 8 commits into from
Oct 6, 2023
Merged

Conversation

DaryaYuk
Copy link
Contributor

@DaryaYuk DaryaYuk commented Oct 1, 2023

This PR

  • Updates README.md to follow new template

Related Issues

Fixes #145

Notes

As far as I understood, the Eventing feature and the Shutdown feature haven't been implemented yet

@DaryaYuk DaryaYuk requested a review from a team as a code owner October 1, 2023 18:53
@DaryaYuk DaryaYuk force-pushed the docs/update-readme branch from fca13c2 to 417a97a Compare October 1, 2023 18:59
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #155 (f8e1f1d) into main (9c42d4a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files          20       20           
  Lines         542      542           
  Branches       39       39           
=======================================
  Hits          509      509           
  Misses         20       20           
  Partials       13       13           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. I left a few comments but overall it looks great.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
<!-- The 'github-badges' class is used in the docs -->
<p align="center" class="github-badges">
<a href="https://github.com/open-feature/spec/tree/v0.6.0">
<img alt="Specification" src="https://img.shields.io/static/v1?label=specification&message=v0.6.0&color=yellow&style=for-the-badge" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like this SDK is v0.6.0 compliment yet. Let's leave it at v0.5.2 until the following issue has been resolved.

#126

DaryaYuk and others added 7 commits October 4, 2023 22:17
Signed-off-by: DaryaYuk <dushistik0811@gmail.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: DaryaYuk <dushistik0811@gmail.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Darya <145902078+DaryaYuk@users.noreply.github.com>
Signed-off-by: DaryaYuk <dushistik0811@gmail.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Darya <145902078+DaryaYuk@users.noreply.github.com>
Signed-off-by: DaryaYuk <dushistik0811@gmail.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Darya <145902078+DaryaYuk@users.noreply.github.com>
Signed-off-by: DaryaYuk <dushistik0811@gmail.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Darya <145902078+DaryaYuk@users.noreply.github.com>
Signed-off-by: DaryaYuk <dushistik0811@gmail.com>
Signed-off-by: DaryaYuk <dushistik0811@gmail.com>
@DaryaYuk DaryaYuk force-pushed the docs/update-readme branch from 5244538 to 592e516 Compare October 4, 2023 19:17
@DaryaYuk DaryaYuk requested a review from beeme1mr October 4, 2023 19:20
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Signed-off-by: DaryaYuk <dushistik0811@gmail.com>
@beeme1mr beeme1mr merged commit b62e21f into open-feature:main Oct 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Update readme to follow new template
2 participants