Issue 3935/3940- enable remote cr #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiilyZhang
force-pushed
the
zhangl/enableRemoteCR
branch
11 times, most recently
from
3784380 to
de917b6
Compare
MaxMcAdam
reviewed
Nov 10, 2023
kube_operator/api_objects.go
Outdated
| return nil | ||
| } | ||
| glog.V(3).Infof(kwlog(fmt.Sprintf("checking if cluster role %s exists...", cr.Name()))) | ||
| //if existingCr, _ := c.Client.RbacV1().ClusterRoles().Get(context.Background(), cr.Name(), metav1.GetOptions{}); existingCr != nil { |
There was a problem hiding this comment.
is the commented out code no longer needed?
kube_operator/api_objects.go
Outdated
| glog.Errorf(kwlog(fmt.Sprintf("unable to delete role binding %s. Error: %v", crb.ClusterRolebindingObject.ObjectMeta.Name, err))) | ||
| } | ||
| } else { | ||
| glog.V(3).Infof(kwlog(fmt.Sprintf("assign remain subjects %v to existing clusterrolebinding: %v", remainSubjects, existingCRB))) |
There was a problem hiding this comment.
change to "assign remaining..."
kube_operator/api_objects.go
Outdated
| rb_sub := &sub | ||
| if sub.Namespace != "" && sub.Namespace != namespace { | ||
| rb_sub.Namespace = namespace | ||
| /* |
There was a problem hiding this comment.
should this yaml be removed?
dlarson04
approved these changes
Nov 10, 2023
…ll to use remote image registry Signed-off-by: Le Zhang <zhangl@us.ibm.com>
LiilyZhang
force-pushed
the
zhangl/enableRemoteCR
branch
from
de917b6 to
cf2f12e
Compare
MaxMcAdam
approved these changes
Nov 10, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist: