Improve the polling of agbot checks the secrets update #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiilyZhang
force-pushed
the
zhangl/AgbotPullSecretUpdateImprove
branch
from
8da5e62 to
81fe08e
Compare
LiilyZhang
force-pushed
the
zhangl/AgbotPullSecretUpdateImprove
branch
from
81fe08e to
3ae98b5
Compare
dlarson04
requested changes
Nov 4, 2024
config/constants.go
Outdated
| @@ -138,5 +138,11 @@ const K8sCRInstallTimeoutS_DEFAULT = 180 | |||
| // Time between secret update checks | |||
| const SecretsUpdateCheck_DEFAULT = 60 | |||
|
|
|||
| // Max interval between secret update checks | |||
| const SecretsUpdateCheckMaxInterval_DEFAULT = 600 | |||
There was a problem hiding this comment.
I think a default of 10 minutes is too long but we can discuss a better value
config/config.go
Outdated
| @@ -132,7 +132,9 @@ type AGConfig struct { | |||
| RetryLookBackWindow uint64 // The time window (in seconds) used by the agbot to look backward in time for node changes when node agreements are retried. | |||
| PolicySearchOrder bool // When true, search policies from most recently changed to least recently changed. | |||
| Vault VaultConfig // The hashicorp vault config to connect to and fetch secrets from. | |||
| SecretsUpdateCheck int // The number of seconds between checks for updated secrets. | |||
| SecretsUpdateCheckInterval int // The number of seconds between checks for updated secrets. Default is 60 | |||
| SecretsUpdateCheckMaxInterval int // As the runtime increases the ExchangeMessagePollInterval, this value is the maximum that value can attain. | |||
There was a problem hiding this comment.
This comment says ExchangeMessagePollInterval...
LiilyZhang
force-pushed
the
zhangl/AgbotPullSecretUpdateImprove
branch
2 times, most recently
from
0c3b1b4 to
7cf7bd6
Compare
… update Signed-off-by: Le Zhang <zhangl@us.ibm.com>
LiilyZhang
force-pushed
the
zhangl/AgbotPullSecretUpdateImprove
branch
from
7cf7bd6 to
bc8ec75
Compare
dlarson04
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist: