fix writeTimeoutPacket vuln

[RnkSngh]

Quick PR to fix the vuln in writetimeoutpacket to check for proofs before writing a timeout. Since we're checking for a proof of the packet existing in the ibc state, an arbitrary packet with only the timeout changed cannot be spoofed now.

Note that this doesn't patch the vuln for channels which use the dummy light client, though this seems to be expected that these channels in general are not secure

Summary by CodeRabbit

• New Features

  • Enhanced security for packet processing in the Dispatcher contract by requiring an additional verification proof (Ics23Proof).

• Tests

  • Added a new test to validate the prevention of packet spoofing in timeout scenarios.

• Refactor

  • Updated the writeTimeoutPacket function across contracts and interfaces to include proof verification.

[coderabbitai]

Walkthrough

The recent updates focus on enhancing security and functionality in the Dispatcher.sol contract by requiring an Ics23Proof for the writeTimeoutPacket function. This additional verification step ensures the integrity of packet timeouts. Changes are also mirrored in interface updates and test enhancements to support these modifications.

Changes

File Path	Change Summary
contracts/core/Dispatcher.sol, contracts/interfaces/IDispatcher.sol	Added Ics23Proof parameter to writeTimeoutPacket for enhanced verification.
test/Dispatcher.t.sol	Updated src address and added test_writeTimeoutPacket_cannot_Spoof_Packet to prevent spoofing.
test/upgradeableProxy/upgrades/DispatcherV2.sol	Updated writeTimeoutPacket function to include Ics23Proof parameter and verification logic.

Possibly related issues

• vibc-core-smart-contracts: add packet-timeout support (requires opverifier non-membership proofs) #65: The addition of the Ics23Proof parameter aligns with the objectives to utilize non-membership proofs for packet-timeout features, enhancing security and integrity as outlined in the issue.

🐇💬
Oh, hoppity hop, in the code we weave,
A proof so strong, deceivers can't deceive.
Packets time out, but with grace they leave,
With proofs in place, we all believe.
🌟📜✨

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 5a8010a and 787cbe3.

Files selected for processing (1)

• contracts/core/Dispatcher.sol (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• contracts/core/Dispatcher.sol

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[dshiell]

this looks correct to me!