MINOR: Make Include ddl disabled by default 1.4.7 (#17453)

open-metadata · Aug 14, 2024 · 33ff59a · 33ff59a
1 parent 8e17798
commit 33ff59a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ingestion/src/metadata/ingestion/source/database/common_db_source.py b/ingestion/src/metadata/ingestion/source/database/common_db_source.py
@@ -371,7 +371,7 @@ def get_schema_definition(
                 schema_definition = inspector.get_view_definition(
                     table_name, schema_name
                 )
-            elif hasattr(inspector, "get_table_ddl"):
+            elif hasattr(inspector, "get_table_ddl") and self.source_config.includeDDL:
                 schema_definition = inspector.get_table_ddl(
                     self.connection, table_name, schema_name
                 )
@@ -383,11 +383,11 @@ def get_schema_definition(
             return schema_definition
 
         except NotImplementedError:
-            logger.warning("Schema definition not implemented")
+            logger.debug("Schema definition not implemented")
 
         except Exception as exc:
             logger.debug(traceback.format_exc())
-            logger.warning(f"Failed to fetch schema definition for {table_name}: {exc}")
+            logger.debug(f"Failed to fetch schema definition for {table_name}: {exc}")
         return None
 
     def is_partition(  # pylint: disable=unused-argument

diff --git a/...pec/src/main/resources/json/schema/metadataIngestion/databaseServiceMetadataPipeline.json b/...pec/src/main/resources/json/schema/metadataIngestion/databaseServiceMetadataPipeline.json
@@ -93,7 +93,7 @@
     "includeDDL": {
       "description": "Optional configuration to toggle the DDL Statements ingestion.",
       "type": "boolean",
-      "default": true,
+      "default": false,
       "title": "Include DDL Statements"
     },
     "queryLogDuration": {