FIX: Mask Slack App User & Bot Tokens (#18814)

* fix: mask slack user and bot token. * refactor: Move the code in SlackApp
open-metadata · Nov 28, 2024 · 3453c79 · 3453c79
1 parent 8fcb8ec
commit 3453c79
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/openmetadata-service/src/main/java/org/openmetadata/service/resources/apps/AppResource.java b/openmetadata-service/src/main/java/org/openmetadata/service/resources/apps/AppResource.java
@@ -1135,7 +1135,6 @@ private App getApplication(
 
     // validate Bot if provided
     validateAndAddBot(app, createAppRequest.getBot());
-
     return app;
   }
 

diff --git a/...es/json/schema/entity/applications/configuration/external/slackAppTokenConfiguration.json b/...es/json/schema/entity/applications/configuration/external/slackAppTokenConfiguration.json
@@ -9,12 +9,14 @@
     "userToken": {
       "title": "User Token",
       "description": "User Token",
-      "type": "string"
+      "type": "string",
+      "format": "password"
     },
     "botToken": {
       "title": "Bot Token",
       "description": "Bot Token",
-      "type": "string"
+      "type": "string",
+      "format": "password"
     }
   },
   "additionalProperties": false,
-Original file line number
+Diff line change
@@ Expand Up / @@ -1135,7 +1135,6 @@ private App getApplication( @@
         // validate Bot if provided
         validateAndAddBot(app, createAppRequest.getBot());
         return app;
       }
@@ Expand Down @@