Merge branch 'main' into data_insight_refactor

ingestion/tests/unit/test_column_type_parser.py

@@ -127,7 +127,7 @@ def test_check_datalake_type():
         "column10": DataType.JSON,
         "column11": DataType.ARRAY,
     }
-    df = pd.read_csv("ingestion/tests/unit/test_column_type_parser.csv")
+    df = pd.read_csv(root + "/test_column_type_parser.csv")
     for column_name in df.columns.values.tolist():
         assert assert_col_type_dict.get(
             column_name

ingestion/tests/unit/test_protobuf_parser.py

@@ -100,7 +100,7 @@ def test_complex_protobuf_schema_files(self):
         We'll read the files under ./ingestion/tests/unit/resources/protobuf_parser and parse them
         This will be similar in way to how we get the data from kafka source
         """
-        resource_path = "./ingestion/tests/unit/resources/protobuf_parser/"
+        resource_path = f"{os.path.dirname(__file__)}/resources/protobuf_parser/"
         schema_name = "employee"
         file_list = os.listdir(resource_path)
         schema_text = ""

ingestion/tests/unit/test_sample_usage.py

@@ -13,6 +13,7 @@
 Query parser utils tests
 """
 import json
+import os.path
 from unittest import TestCase
 
 from metadata.workflow.usage import UsageWorkflow
@@ -78,7 +79,17 @@ def test_join_count(self):
             "shopify.fact_sale": 3,
             "shopify.raw_customer": 10,
         }
-        workflow = UsageWorkflow.create(json.loads(config))
+        config_dict = json.loads(config)
+        config_dict["source"]["serviceConnection"]["config"]["connectionOptions"][
+            "sampleDataFolder"
+        ] = (
+            os.path.dirname(__file__)
+            + "/../../../"
+            + config_dict["source"]["serviceConnection"]["config"]["connectionOptions"][
+                "sampleDataFolder"
+            ]
+        )
+        workflow = UsageWorkflow.create(config_dict)
         workflow.execute()
         table_usage_map = {}
 

openmetadata-docs/content/v1.3.x/deployment/ingestion/external/index.md

@@ -15,6 +15,10 @@ component that can be run from - **literally** - anywhere.
 
 In order to install it, you just need to get it from [PyPI](https://pypi.org/project/openmetadata-ingestion/).
 
+```shell
+pip install openmetadata-ingestion
+```
+
 We will show further examples later, but a piece of code is the best showcase for its simplicity. In order to run
 a full ingestion process, you just need to execute a single function. For example, if we wanted to run the metadata 
 ingestion from within a simple Python script:

openmetadata-docs/content/v1.4.x/deployment/ingestion/external/index.md

@@ -17,6 +17,10 @@ component that can be run from - **literally** - anywhere.
 
 In order to install it, you just need to get it from [PyPI](https://pypi.org/project/openmetadata-ingestion/).
 
+```shell
+pip install openmetadata-ingestion
+```
+
 We will show further examples later, but a piece of code is the best showcase for its simplicity. In order to run
 a full ingestion process, you just need to execute a single function. For example, if we wanted to run the metadata 
 ingestion from within a simple Python script:

openmetadata-docs/content/v1.5.x-SNAPSHOT/deployment/ingestion/external/index.md

@@ -17,6 +17,10 @@ component that can be run from - **literally** - anywhere.
 
 In order to install it, you just need to get it from [PyPI](https://pypi.org/project/openmetadata-ingestion/).
 
+```shell
+pip install openmetadata-ingestion
+```
+
 We will show further examples later, but a piece of code is the best showcase for its simplicity. In order to run
 a full ingestion process, you just need to execute a single function. For example, if we wanted to run the metadata
 ingestion from within a simple Python script:

openmetadata-ui/src/main/resources/ui/cypress/common/TaskUtils.ts

@@ -100,6 +100,10 @@ export const createDescriptionTask = (
     // select value from dropdown
     verifyResponseStatusCode('@suggestApi', 200);
 
+    cy.get(
+      '.ant-select-dropdown .rc-virtual-list .rc-virtual-list-holder-inner'
+    ).should('be.visible');
+
     cy.get(`[data-testid="${value.assignee ?? assignee}"]`)
       .should('be.visible')
       .trigger('mouseover')

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/TestCases.spec.ts

@@ -119,7 +119,7 @@ test('Table difference test case', async ({ page }) => {
     await test.step('Delete', async () => {
       await deleteTestCase(page, testCase.name);
     });
-  } catch (error) {
+  } finally {
     await table1.delete(apiContext);
     await table2.delete(apiContext);
 
@@ -212,7 +212,7 @@ test('Custom SQL Query', async ({ page }) => {
     await test.step('Delete', async () => {
       await deleteTestCase(page, testCase.name);
     });
-  } catch (error) {
+  } finally {
     await table.delete(apiContext);
     await afterAction();
   }

openmetadata-ui/src/main/resources/ui/src/components/DataQuality/AddDataQualityTest/EditTestCaseModal.tsx

@@ -44,6 +44,7 @@ import {
 } from '../../../utils/EntityUtils';
 import { getEntityFQN } from '../../../utils/FeedUtils';
 import { generateFormFields } from '../../../utils/formUtils';
+import { isValidJSONString } from '../../../utils/StringsUtils';
 import { showErrorToast, showSuccessToast } from '../../../utils/ToastUtils';
 import Loader from '../../common/Loader/Loader';
 import RichTextEditor from '../../common/RichTextEditor/RichTextEditor';
@@ -144,7 +145,10 @@ const EditTestCaseModal: React.FC<EditTestCaseModalProps> = ({
         (definition) => definition.name === curr.name
       );
 
-      if (param?.dataType === TestDataType.Array) {
+      if (
+        param?.dataType === TestDataType.Array &&
+        isValidJSONString(curr.value)
+      ) {
         const value = JSON.parse(curr.value || '[]');
 
         return {

openmetadata-ui/src/main/resources/ui/src/components/DataQuality/IncidentManager/TestCaseResultTab/TestCaseResultTab.component.tsx

@@ -45,7 +45,11 @@ import testCaseResultTabClassBase from './TestCaseResultTabClassBase';
 
 const TestCaseResultTab = () => {
   const { t } = useTranslation();
-  const { testCase: testCaseData, setTestCase } = useTestCaseStore();
+  const {
+    testCase: testCaseData,
+    setTestCase,
+    showAILearningBanner,
+  } = useTestCaseStore();
   const additionalComponent =
     testCaseResultTabClassBase.getAdditionalComponents();
   const [isDescriptionEdit, setIsDescriptionEdit] = useState<boolean>(false);
@@ -116,6 +120,11 @@ const TestCaseResultTab = () => {
     []
   );
 
+  const AlertComponent = useMemo(
+    () => testCaseResultTabClassBase.getAlertBanner(),
+    []
+  );
+
   const testCaseParams = useMemo(() => {
     if (testCaseData?.useDynamicAssertion) {
       return (
@@ -224,6 +233,13 @@ const TestCaseResultTab = () => {
         </Col>
       ) : null}
 
+      {showAILearningBanner &&
+        testCaseData?.useDynamicAssertion &&
+        AlertComponent && (
+          <Col span={24}>
+            <AlertComponent />
+          </Col>
+        )}
       {testCaseData && (
         <Col className="test-case-result-tab-graph" span={24}>
           <TestSummary data={testCaseData} />

openmetadata-ui/src/main/resources/ui/src/components/DataQuality/IncidentManager/TestCaseResultTab/TestCaseResultTab.test.tsx

@@ -22,7 +22,7 @@ import { TestCase } from '../../../../generated/tests/testCase';
 import { checkPermission } from '../../../../utils/PermissionsUtils';
 import TestCaseResultTab from './TestCaseResultTab.component';
 
-const mockTestCaseData = {
+const mockTestCaseData: TestCase = {
   id: '1b748634-d24b-4879-9791-289f2f90fc3c',
   name: 'table_column_count_equals',
   fullyQualifiedName:
@@ -68,6 +68,7 @@ const mockTestCaseData = {
 const mockUseTestCaseStore = {
   testCase: mockTestCaseData,
   setTestCase: jest.fn(),
+  showAILearningBanner: false,
 };
 
 jest.mock(
@@ -76,6 +77,11 @@ jest.mock(
     useTestCaseStore: jest.fn().mockImplementation(() => mockUseTestCaseStore),
   })
 );
+const mockBannerComponent = () => <div>BannerComponent</div>;
+jest.mock('./TestCaseResultTabClassBase', () => ({
+  getAdditionalComponents: jest.fn().mockReturnValue([]),
+  getAlertBanner: jest.fn().mockImplementation(() => mockBannerComponent),
+}));
 jest.mock('../../../common/EntityDescription/DescriptionV1', () => {
   return jest.fn().mockImplementation(() => <div>DescriptionV1</div>);
 });
@@ -189,4 +195,32 @@ describe('TestCaseResultTab', () => {
 
     mockUseTestCaseStore.testCase.useDynamicAssertion = false;
   });
+
+  it('Should show banner if banner component is available, useDynamicAssertion and showAILearningBanner is true', async () => {
+    mockTestCaseData.useDynamicAssertion = true;
+    mockUseTestCaseStore.showAILearningBanner = true;
+
+    render(<TestCaseResultTab />);
+
+    const bannerComponent = await screen.findByText('BannerComponent');
+
+    expect(bannerComponent).toBeInTheDocument();
+
+    mockTestCaseData.useDynamicAssertion = false;
+    mockUseTestCaseStore.showAILearningBanner = false;
+  });
+
+  it('Should not show banner if banner component is available, useDynamicAssertion is false and showAILearningBanner is true', async () => {
+    mockTestCaseData.useDynamicAssertion = false;
+    mockUseTestCaseStore.showAILearningBanner = true;
+
+    render(<TestCaseResultTab />);
+
+    const bannerComponent = screen.queryByText('BannerComponent');
+
+    expect(bannerComponent).not.toBeInTheDocument();
+
+    mockTestCaseData.useDynamicAssertion = false;
+    mockUseTestCaseStore.showAILearningBanner = false;
+  });
 });

openmetadata-ui/src/main/resources/ui/src/components/DataQuality/IncidentManager/TestCaseResultTab/TestCaseResultTabClassBase.ts

@@ -21,6 +21,10 @@ class TestCaseResultTabClassBase {
   public getAdditionalComponents(): Array<AdditionalComponentInterface> {
     return [];
   }
+
+  public getAlertBanner(): React.FC | null {
+    return null;
+  }
 }
 
 const testCaseResultTabClassBase = new TestCaseResultTabClassBase();

openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TestSummary/TestSummaryGraph.test.tsx

@@ -150,6 +150,15 @@ jest.mock(
     })),
   })
 );
+const mockSetShowAILearningBanner = jest.fn();
+jest.mock(
+  '../../../../pages/IncidentManager/IncidentManagerDetailPage/useTestCase.store',
+  () => ({
+    useTestCaseStore: jest.fn().mockImplementation(() => ({
+      setShowAILearningBanner: mockSetShowAILearningBanner,
+    })),
+  })
+);
 
 describe('TestSummaryGraph', () => {
   it('should display error placeholder when the result data is empty', () => {
@@ -214,4 +223,10 @@ describe('TestSummaryGraph', () => {
     expect(minLineChart).toBeInTheDocument();
     expect(maxLineChart).toBeInTheDocument();
   });
+
+  it('should call mockSetShowAILearningBanner', () => {
+    render(<TestSummaryGraph {...mockProps} />);
+
+    expect(mockSetShowAILearningBanner).toHaveBeenCalledWith(false);
+  });
 });

openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TestSummary/TestSummaryGraph.tsx

@@ -51,6 +51,7 @@ import {
   ThreadTaskStatus,
 } from '../../../../generated/entity/feed/thread';
 import { TestCaseStatus } from '../../../../generated/tests/testCase';
+import { useTestCaseStore } from '../../../../pages/IncidentManager/IncidentManagerDetailPage/useTestCase.store';
 import {
   axisTickFormatter,
   updateActiveChartFilter,
@@ -72,6 +73,7 @@ function TestSummaryGraph({
 }: Readonly<TestSummaryGraphProps>) {
   const { t } = useTranslation();
   const { entityThread = [] } = useActivityFeedProvider();
+  const { setShowAILearningBanner } = useTestCaseStore();
   const chartRef = useRef(null);
   const [chartMouseEvent, setChartMouseEvent] =
     useState<CategoricalChartState>();
@@ -91,11 +93,14 @@ function TestSummaryGraph({
   }, [chartRef, chartMouseEvent]);
 
   const chartData = useMemo(() => {
-    return prepareChartData({
+    const data = prepareChartData({
       testCaseParameterValue: testCaseParameterValue ?? [],
       testCaseResults,
       entityThread,
     });
+    setShowAILearningBanner(data.showAILearningBanner);
+
+    return data;
   }, [testCaseResults, entityThread, testCaseParameterValue]);
 
   const incidentData = useMemo(() => {

openmetadata-ui/src/main/resources/ui/src/components/common/RichTextEditor/CustomHtmlRederer/CustomHtmlRederer.tsx

@@ -27,7 +27,7 @@ import { t } from 'i18next';
 import katex from 'katex';
 import React from 'react';
 import ReactDOMServer from 'react-dom/server';
-import { ReactComponent as CopyIcon } from '../../../../assets/svg/icon-copy.svg';
+import CopyIcon from '../../../../assets/svg/icon-copy.svg';
 import {
   markdownTextAndIdRegex,
   MARKDOWN_MATCH_ID,
@@ -116,9 +116,14 @@ export const customHTMLRenderer: CustomHTMLRenderer = {
               data-testid="copied-message">
               {t('label.copied')}
             </span>
-            <span data-testid="code-block-copy-icon">
-              <CopyIcon className="code-copy-button" data-copied="false" />
-            </span>
+            <img
+              className="code-copy-button"
+              data-copied="false"
+              data-testid="code-block-copy-icon"
+              height={24}
+              src={CopyIcon}
+              width={24}
+            />
           </>
         ),
       },

openmetadata-ui/src/main/resources/ui/src/components/common/RichTextEditor/rich-text-editor-previewer.less

@@ -232,15 +232,14 @@
       }
     }
     .code-copy-button {
+      display: none;
       position: absolute;
-      top: 16px;
+      top: 8px;
       right: 40px;
       pointer-events: all;
       cursor: pointer;
       z-index: 1;
-      width: 16px;
-      opacity: 0;
-      padding: 8px;
+      padding: 2px;
       background: @border-color;
       border-radius: 4px;
     }
@@ -260,7 +259,7 @@
 
     .code-block {
       &:hover .code-copy-button[data-copied='false'] {
-        opacity: 1;
+        display: inline-block;
       }
     }
 

openmetadata-ui/src/main/resources/ui/src/pages/IncidentManager/IncidentManagerDetailPage/IncidentManagerDetailPage.test.tsx

@@ -76,6 +76,8 @@ const mockUseTestCase: UseTestCaseStoreInterface = {
   isLoading: false,
   setIsLoading: jest.fn(),
   reset: jest.fn(),
+  showAILearningBanner: false,
+  setShowAILearningBanner: jest.fn(),
 };
 jest.mock('./useTestCase.store', () => ({
   useTestCaseStore: jest.fn().mockImplementation(() => mockUseTestCase),

openmetadata-ui/src/main/resources/ui/src/pages/IncidentManager/IncidentManagerDetailPage/useTestCase.store.ts

@@ -16,20 +16,26 @@ import { TestCase } from '../../../generated/tests/testCase';
 export interface UseTestCaseStoreInterface {
   testCase: TestCase | undefined;
   isLoading: boolean;
+  showAILearningBanner: boolean;
   setTestCase: (testCase: TestCase) => void;
   setIsLoading: (isLoading: boolean) => void;
+  setShowAILearningBanner: (showBanner: boolean) => void;
   reset: () => void;
 }
 export const useTestCaseStore = create<UseTestCaseStoreInterface>()((set) => ({
   testCase: undefined,
   isLoading: true,
+  showAILearningBanner: false,
   setTestCase: (testCase: TestCase) => {
     set({ testCase });
   },
   setIsLoading: (isLoading: boolean) => {
     set({ isLoading });
   },
+  setShowAILearningBanner: (showAILearningBanner: boolean) => {
+    set({ showAILearningBanner });
+  },
   reset: () => {
-    set({ testCase: undefined, isLoading: true });
+    set({ testCase: undefined, isLoading: true, showAILearningBanner: false });
   },
 }));