Minor: add column name to test case header (#18938)

* fix: add column name to test case header * test: add test case for column name * fix: return statement for columnName * refactor: remove replacePlus function call --------- Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
open-metadata · Dec 17, 2024 · c96c778 · c96c778
1 parent bd68d95
commit c96c778
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/...Quality/IncidentManager/IncidentManagerPageHeader/IncidentManagerPageHeader.component.tsx b/...Quality/IncidentManager/IncidentManagerPageHeader/IncidentManagerPageHeader.component.tsx
@@ -41,7 +41,10 @@ import {
   updateTestCaseIncidentById,
 } from '../../../../rest/incidentManagerAPI';
 import { getNameFromFQN } from '../../../../utils/CommonUtils';
-import { getEntityName } from '../../../../utils/EntityUtils';
+import {
+  getColumnNameFromEntityLink,
+  getEntityName,
+} from '../../../../utils/EntityUtils';
 import { getEntityFQN } from '../../../../utils/FeedUtils';
 import { checkPermission } from '../../../../utils/PermissionsUtils';
 import { getDecodedFqn } from '../../../../utils/StringsUtils';
@@ -76,6 +79,17 @@ const IncidentManagerPageHeader = ({
     initialAssignees,
   } = useActivityFeedProvider();
 
+  const columnName = useMemo(() => {
+    const isColumn = testCaseData?.entityLink.includes('::columns::');
+    if (isColumn) {
+      const name = getColumnNameFromEntityLink(testCaseData?.entityLink ?? '');
+
+      return name;
+    }
+
+    return null;
+  }, [testCaseData]);
+
   const tableFqn = useMemo(
     () => getEntityFQN(testCaseData?.entityLink ?? ''),
     [testCaseData]
@@ -327,6 +341,17 @@ const IncidentManagerPageHeader = ({
           </Typography.Text>
         </>
       )}
+      {columnName && (
+        <>
+          <Divider className="self-center m-x-sm" type="vertical" />
+          <Typography.Text className="self-center text-xs whitespace-nowrap">
+            <span className="text-grey-muted">{`${t('label.column')}: `}</span>
+            <span className="font-medium" data-testid="test-column-name">
+              {columnName}
+            </span>
+          </Typography.Text>
+        </>
+      )}
       <Divider className="self-center m-x-sm" type="vertical" />
       <Typography.Text className="self-center text-xs whitespace-nowrap">
         <span className="text-grey-muted">{`${t('label.test-type')}: `}</span>

diff --git a/.../DataQuality/IncidentManager/IncidentManagerPageHeader/IncidentManagerPageHeader.test.tsx b/.../DataQuality/IncidentManager/IncidentManagerPageHeader/IncidentManagerPageHeader.test.tsx
@@ -104,6 +104,9 @@ jest.mock('../../../../utils/CommonUtils', () => ({
 
 jest.mock('../../../../utils/EntityUtils', () => ({
   getEntityName: jest.fn().mockReturnValue('getEntityName'),
+  getColumnNameFromEntityLink: jest
+    .fn()
+    .mockReturnValue('getColumnNameFromEntityLink'),
 }));
 
 jest.mock('../../../../utils/FeedUtils', () => ({
@@ -270,5 +273,8 @@ describe('Incident Manager Page Header component', () => {
     // Test Type
     expect(screen.getByText('label.test-type:')).toBeInTheDocument();
     expect(screen.getByText('getEntityName')).toBeInTheDocument();
+    // If Column is present
+    expect(screen.getByText('label.column:')).toBeInTheDocument();
+    expect(screen.getByText('getColumnNameFromEntityLink')).toBeInTheDocument();
   });
 });