Return s3 endpoint as str() instead of Url (#18521)

open-metadata · Nov 5, 2024 · dccba20 · dccba20
1 parent e9a888f
commit dccba20
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/ingestion/src/metadata/ingestion/source/database/iceberg/fs/s3.py b/ingestion/src/metadata/ingestion/source/database/iceberg/fs/s3.py
@@ -67,7 +67,7 @@ def get_fs_params(cls, fs_config: FileSystemConfig) -> dict:
             )
 
         return {
-            S3_ENDPOINT: fs_config.endPointURL,
+            S3_ENDPOINT: str(fs_config.endPointURL),
             S3_ACCESS_KEY_ID: fs_config.awsAccessKeyId,
             S3_SECRET_ACCESS_KEY: fs_config.awsSecretAccessKey.get_secret_value()
             if fs_config.awsSecretAccessKey

diff --git a/ingestion/tests/unit/topology/database/test_iceberg.py b/ingestion/tests/unit/topology/database/test_iceberg.py
@@ -464,6 +464,7 @@
                     "connection": {
                         "tableName": "table",
                         "awsConfig": {
+                            "endPointURL": "http://example.com",
                             "awsAccessKeyId": "access_key",
                             "awsSecretAccessKey": "secret",
                             "awsRegion": "us-east-2",