Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): reverted the ES config step for 'Data Insights Pipeline' #12121

Merged
merged 4 commits into from
Jun 24, 2023
Merged

fix(UI): reverted the ES config step for 'Data Insights Pipeline' #12121

merged 4 commits into from
Jun 24, 2023

Conversation

aniketkatkar97
Copy link
Member

Describe your changes:

I worked on reverting back the ES config form in Data Insights Pipeline configuration step

Screen.Recording.2023-06-23.at.5.38.56.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added the UI UI specific issues label Jun 23, 2023
@aniketkatkar97 aniketkatkar97 self-assigned this Jun 23, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jun 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 49.05% (19704/40171) 28.08% (7193/25618) 29.42% (2189/7440)

chirag-madlani
chirag-madlani previously approved these changes Jun 23, 2023
View reviewed changes
@chirag-madlani chirag-madlani temporarily deployed to test June 23, 2023 16:31 — with GitHub Actions Inactive
@chirag-madlani chirag-madlani temporarily deployed to test June 23, 2023 16:31 — with GitHub Actions Inactive
@chirag-madlani chirag-madlani temporarily deployed to test June 23, 2023 16:31 — with GitHub Actions Inactive
@cypress
Copy link

cypress bot commented Jun 23, 2023 •
edited
Loading

Passing run #24751 ↗︎

0 249 59 0 Flakiness 0

Details:

Merge branch 'main' into fix-es-config-form
Project: openmetadata Commit: d1222cf378
Status: Passed Duration: 26:57 💡
Started: Jun 24, 2023 10:18 AM Ended: Jun 24, 2023 10:45 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ulixius9 ulixius9 requested a review from a team as a code owner June 24, 2023 09:54
@chirag-madlani chirag-madlani temporarily deployed to test June 24, 2023 09:55 — with GitHub Actions Inactive
@chirag-madlani chirag-madlani temporarily deployed to test June 24, 2023 09:55 — with GitHub Actions Inactive
@chirag-madlani chirag-madlani temporarily deployed to test June 24, 2023 09:55 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2023

[open-metadata-airflow-apis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2023

[OpenMetadata-Platform] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@chirag-madlani chirag-madlani merged commit 67ffa1c into main Jun 24, 2023
23 of 26 checks passed
@chirag-madlani chirag-madlani deleted the fix-es-config-form branch June 24, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@shahsank3t shahsank3t Awaiting requested review from shahsank3t

Assignees

@aniketkatkar97 aniketkatkar97

Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aniketkatkar97 @chirag-madlani @ulixius9