Address backend DQ feedback #12150
Merged
Address backend DQ feedback #12150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backend
Ingestion
safe to test
Passing run #24870 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!
|
|
[OpenMetadata-Platform] Kudos, SonarCloud Quality Gate passed! |
mohityadav766
approved these changes
Jun 27, 2023
harshach
approved these changes
Jun 27, 2023
harshach
pushed a commit
that referenced
this pull request
Jun 28, 2023
* fix: add jp and zh index * fix: updated testCase tooltips * fix: changed list testSuite permission to VEW_TEST + set owner of table for executable testSuite
mohityadav766
added a commit
that referenced
this pull request
Jun 28, 2023
…disabled (#12144) * Fix #10198: Filter tags and classifications if the classification is disabled * Fix #10198: Fix tests * Fix #10198: Fix tests * Fix #10198: Fix Postgres tests * Fix #10198: Fix Postgres tests * Fix #12083 - Backoff retry when polling for pipeline service client status (#12105) * Fix #12083 * Fix #12083 --------- Co-authored-by: Sriharsha Chintalapani <harshach@users.noreply.github.com> * Databricks Support Table Constraints (#12138) * Databricks Support Table Constraints * pylint fix --------- Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com> * Fix #11659: Add support for filter patterns in dbt workflow (#12063) * Move Top Level Imports (#12145) * interfaces for db migrations (#12057) * interfaces for db migrations * Add Data Migration for entities to 1.1 * Migration for FQN hash * Added Tag Usage And Fixed some transaction issue in testing * Added SERVER_CHANGE_LOG validations * Update Path for files * Added Postgres Migration * Test Suite Migration [WIP] * remove ingestion pipeline * moved Migration to Table Initializer * init Data source config in TableInitializer * make checksum ignore configurable --------- Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com> * Fix Migrations (#12146) * Mask queries, Table sample data and Topic sample data (#12139) * Filter out PII queries * Mask topic PII * Mask topic PII * Update sample data test * Format * Moved logic to repository or PIIMasker * Fix test * chore(ui): update sample data api endpoint for topic --------- Co-authored-by: Sachin Chaurasiya <sachinchaurasiyachotey87@gmail.com> * Dockerfile Update (#11066) * Updating Dockerfile with multistage * Updating reviewed changes * Docker Development changes * Docker workflow changes * Arguments update * Script path update * Arguments update * Resolving the reviewed suggestions * Docker script update (#12115) * Create manual.yml * Fixing Typo * Removing manual test github action file * Testing IP runner * Updating docker script for sandbox db task * removing the ip test action * Updating docker script for sandbox db task postgres * Volume cleaning argument addition * Volume cleaning argument addition * Fix Failing Maven CI Test (#12151) * Fix SQLLineage Test (#12152) * Docker server workflow (#12157) * Updating Dockerfile with multistage * Updating reviewed changes * Docker Development changes * Docker workflow changes * Arguments update * Script path update * Arguments update * Resolving the reviewed suggestions * updating workflow syntax * remvoed ibm db arch (#12158) * fix: resolve general feedbacks (#12153) * fix: feedbacks * fix: add tier as static item * fix: feedbacks * fix: add localization * fix: feedbacks * fix: add localization * fix: breadcrumb wrapping issue * fix: alignment issue for glossary * fix: border issue in drawer * ui: worked on DQ feedback part 3 (#12149) * ui: worked on DQ feedback part 3 * updated name of test suite ingestion name - Added description field in test case expand view - Added functionality to update displayname of test case * added testCase in re-indexing * integrated permission in DQ * fix: check on undefined bool value of clause (#12162) * chore(ui): task feedback (#12154) * chore(ui): task feedback * fix copy notification info * fix code font * fix glue pipeline * fix unit tests * fix cy failures * Update CODEOWNERS for UI code * Address backend DQ feedback (#12150) * fix: add jp and zh index * fix: updated testCase tooltips * fix: changed list testSuite permission to VEW_TEST + set owner of table for executable testSuite * Run System Migrations on CREATE * Update logging messages for JWT tokens (#12169) * Update Test Case Activity Feed Messaging * Auto tagging Windows troubleshooting (#12173) * feat(ui): supported pagination and search in tags and term select for both table and entity level (#12155) * supported pagination and search in tags and term select for both table and entity level * supported pagination of tags in glossary overiew section for tags * fix cypress and address comments * fix cypress issue * fixed(ui): updated tour flow and feedback (#12171) * fixed(ui): updated tour flow and feedback * translation-sync * addressing comments * feat: added view definition tab in table details page (#12172) * Update profiler dq doc (#12182) * doc: update documentation for profiler and dq * doc: renamed image path from 1.0.0 to 1.1.0 * fix connection kwargs error in profiler (#12181) * Fix Profiler Workflow infinite loop (#12185) * Fix Profiler Workflow infinite loop * fix: scrolling behavior feedback on mydata page (#12176) * fix(ui): task layout update (#12175) * fix(ui): task layout update * fix title for edit task * remove local for edit-task * feat(ui): supported pagination of glossary terms in glossary overview section (#12177) * supported pagination of glossary terms in glossay overview section * remove unwanted try catch * change as per comments * Update S3 storage permissions (#12064) * Add disabled flag to search mappings * Revert unwanted changes --------- Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com> Co-authored-by: Mayur Singal <39544459+ulixius9@users.noreply.github.com> Co-authored-by: Ayush Shah <ayush@getcollate.io> Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com> Co-authored-by: Sachin Chaurasiya <sachinchaurasiyachotey87@gmail.com> Co-authored-by: Anuj359 <anuj.j@deuexsolutions.com> Co-authored-by: Mohit Yadav <105265192+mohityadav766@users.noreply.github.com> Co-authored-by: Onkar Ravgan <onkar.10r@gmail.com> Co-authored-by: karanh37 <33024356+karanh37@users.noreply.github.com> Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com> Co-authored-by: Teddy <teddy.crepineau@gmail.com> Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com> Co-authored-by: Ashish Gupta <ashish@getcollate.io>
harshach
pushed a commit
that referenced
this pull request
Jun 30, 2023
* fix: add jp and zh index * fix: updated testCase tooltips * fix: changed list testSuite permission to VEW_TEST + set owner of table for executable testSuite
harshach
added a commit
that referenced
this pull request
Jun 30, 2023
…disabled (#12144) * Fix #10198: Filter tags and classifications if the classification is disabled * Fix #10198: Fix tests * Fix #10198: Fix tests * Fix #10198: Fix Postgres tests * Fix #10198: Fix Postgres tests * Fix #12083 - Backoff retry when polling for pipeline service client status (#12105) * Fix #12083 * Fix #12083 --------- Co-authored-by: Sriharsha Chintalapani <harshach@users.noreply.github.com> * Databricks Support Table Constraints (#12138) * Databricks Support Table Constraints * pylint fix --------- Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com> * Fix #11659: Add support for filter patterns in dbt workflow (#12063) * Move Top Level Imports (#12145) * interfaces for db migrations (#12057) * interfaces for db migrations * Add Data Migration for entities to 1.1 * Migration for FQN hash * Added Tag Usage And Fixed some transaction issue in testing * Added SERVER_CHANGE_LOG validations * Update Path for files * Added Postgres Migration * Test Suite Migration [WIP] * remove ingestion pipeline * moved Migration to Table Initializer * init Data source config in TableInitializer * make checksum ignore configurable --------- Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com> * Fix Migrations (#12146) * Mask queries, Table sample data and Topic sample data (#12139) * Filter out PII queries * Mask topic PII * Mask topic PII * Update sample data test * Format * Moved logic to repository or PIIMasker * Fix test * chore(ui): update sample data api endpoint for topic --------- Co-authored-by: Sachin Chaurasiya <sachinchaurasiyachotey87@gmail.com> * Dockerfile Update (#11066) * Updating Dockerfile with multistage * Updating reviewed changes * Docker Development changes * Docker workflow changes * Arguments update * Script path update * Arguments update * Resolving the reviewed suggestions * Docker script update (#12115) * Create manual.yml * Fixing Typo * Removing manual test github action file * Testing IP runner * Updating docker script for sandbox db task * removing the ip test action * Updating docker script for sandbox db task postgres * Volume cleaning argument addition * Volume cleaning argument addition * Fix Failing Maven CI Test (#12151) * Fix SQLLineage Test (#12152) * Docker server workflow (#12157) * Updating Dockerfile with multistage * Updating reviewed changes * Docker Development changes * Docker workflow changes * Arguments update * Script path update * Arguments update * Resolving the reviewed suggestions * updating workflow syntax * remvoed ibm db arch (#12158) * fix: resolve general feedbacks (#12153) * fix: feedbacks * fix: add tier as static item * fix: feedbacks * fix: add localization * fix: feedbacks * fix: add localization * fix: breadcrumb wrapping issue * fix: alignment issue for glossary * fix: border issue in drawer * ui: worked on DQ feedback part 3 (#12149) * ui: worked on DQ feedback part 3 * updated name of test suite ingestion name - Added description field in test case expand view - Added functionality to update displayname of test case * added testCase in re-indexing * integrated permission in DQ * fix: check on undefined bool value of clause (#12162) * chore(ui): task feedback (#12154) * chore(ui): task feedback * fix copy notification info * fix code font * fix glue pipeline * fix unit tests * fix cy failures * Update CODEOWNERS for UI code * Address backend DQ feedback (#12150) * fix: add jp and zh index * fix: updated testCase tooltips * fix: changed list testSuite permission to VEW_TEST + set owner of table for executable testSuite * Run System Migrations on CREATE * Update logging messages for JWT tokens (#12169) * Update Test Case Activity Feed Messaging * Auto tagging Windows troubleshooting (#12173) * feat(ui): supported pagination and search in tags and term select for both table and entity level (#12155) * supported pagination and search in tags and term select for both table and entity level * supported pagination of tags in glossary overiew section for tags * fix cypress and address comments * fix cypress issue * fixed(ui): updated tour flow and feedback (#12171) * fixed(ui): updated tour flow and feedback * translation-sync * addressing comments * feat: added view definition tab in table details page (#12172) * Update profiler dq doc (#12182) * doc: update documentation for profiler and dq * doc: renamed image path from 1.0.0 to 1.1.0 * fix connection kwargs error in profiler (#12181) * Fix Profiler Workflow infinite loop (#12185) * Fix Profiler Workflow infinite loop * fix: scrolling behavior feedback on mydata page (#12176) * fix(ui): task layout update (#12175) * fix(ui): task layout update * fix title for edit task * remove local for edit-task * feat(ui): supported pagination of glossary terms in glossary overview section (#12177) * supported pagination of glossary terms in glossay overview section * remove unwanted try catch * change as per comments * Update S3 storage permissions (#12064) * Add disabled flag to search mappings * Revert unwanted changes --------- Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com> Co-authored-by: Mayur Singal <39544459+ulixius9@users.noreply.github.com> Co-authored-by: Ayush Shah <ayush@getcollate.io> Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com> Co-authored-by: Sachin Chaurasiya <sachinchaurasiyachotey87@gmail.com> Co-authored-by: Anuj359 <anuj.j@deuexsolutions.com> Co-authored-by: Mohit Yadav <105265192+mohityadav766@users.noreply.github.com> Co-authored-by: Onkar Ravgan <onkar.10r@gmail.com> Co-authored-by: karanh37 <33024356+karanh37@users.noreply.github.com> Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com> Co-authored-by: Teddy <teddy.crepineau@gmail.com> Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com> Co-authored-by: Ashish Gupta <ashish@getcollate.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes a few bugs from data quality endpoint
VIEW_TESTType of change:
Checklist:
Fixes <issue-number>: <short explanation>I have added a test that covers the exact scenario we are fixing. For complex issues, comment the issue number in the test for future reference.
I have added tests around the new logic.
For connector/ingestion changes: I updated the documentation.