Added quotes for dots while fetching the service names #12230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
|
[open-metadata-airflow-apis] Kudos, SonarCloud Quality Gate passed! |
Passing run #25179 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
ulixius9
approved these changes
Jun 30, 2023
ayush-shah
reviewed
Jun 30, 2023
| sourceConfig=ingestion_pipeline.sourceConfig, | ||
| serviceConnection=None, # retrieved from the test suite workflow using the `sourceConfig.config.entityFullyQualifiedName` | ||
| ) | ||
|
|
||
| if service_type == "databaseService": | ||
| entity_class = DatabaseService | ||
| service: DatabaseService = metadata.get_by_name( | ||
| entity=entity_class, fqn=ingestion_pipeline.service.name | ||
| entity=entity_class, fqn=quote_name(ingestion_pipeline.service.name) |
There was a problem hiding this comment.
instead of modifying all the get_by_name, why not change it in the method itself?
There was a problem hiding this comment.
Yes we can do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Added quotes for dots while fetching the service names
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>