Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12779: Add support for SearchIndexes for ElasticSearch and OpenSearch #12782

Merged
merged 9 commits into from
Aug 10, 2023

Conversation

harshach
Copy link
Collaborator

@harshach harshach commented Aug 7, 2023

…earch

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshach harshach requested a review from a team as a code owner August 7, 2023 20:46
@harshach harshach temporarily deployed to test August 7, 2023 20:46 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 7, 2023 20:46 — with GitHub Actions Inactive
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Aug 7, 2023
@cypress
Copy link

cypress bot commented Aug 7, 2023

1 failed tests on run #27703 ↗︎

1 283 37 0 Flakiness 0

Details:

Fix service count test
Project: openmetadata Commit: e0ac7d75a4
Status: Errored Duration: 24:39 💡
Started: Aug 10, 2023 9:33 PM Ended: Aug 10, 2023 9:58 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@harshach harshach temporarily deployed to test August 8, 2023 06:33 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 8, 2023 06:33 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 8, 2023 06:33 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 8, 2023 06:33 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 8, 2023 06:33 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@harshach harshach temporarily deployed to test August 8, 2023 13:42 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 8, 2023 13:42 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 8, 2023 13:42 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 8, 2023 13:42 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 8, 2023 13:42 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 8, 2023 13:42 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 8, 2023 17:20 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 8, 2023 17:20 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 8, 2023 17:20 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 8, 2023 17:20 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 8, 2023 17:20 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 10, 2023 02:07 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@ulixius9 ulixius9 temporarily deployed to test August 10, 2023 03:16 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test August 10, 2023 03:16 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test August 10, 2023 03:16 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test August 10, 2023 03:16 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test August 10, 2023 03:16 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@ulixius9 ulixius9 temporarily deployed to test August 10, 2023 05:08 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test August 10, 2023 05:08 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test August 10, 2023 05:08 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test August 10, 2023 05:08 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test August 10, 2023 05:08 — with GitHub Actions Inactive
mohityadav766
mohityadav766 previously approved these changes Aug 10, 2023
Copy link
Contributor

@mohityadav766 mohityadav766 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good

@harshach harshach temporarily deployed to test August 10, 2023 21:10 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 10, 2023 21:10 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 10, 2023 21:10 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 10, 2023 21:10 — with GitHub Actions Inactive
@harshach harshach temporarily deployed to test August 10, 2023 21:10 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

69.2% 69.2% Coverage
0.0% 0.0% Duplication

@harshach harshach merged commit 7aaf654 into main Aug 10, 2023
21 of 22 checks passed
@harshach harshach deleted the searchIndexes branch August 10, 2023 23:47
pmbrull added a commit that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants