Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8885 - Misleading 404 logs & suffix cleanup #12916

Merged
merged 11 commits into from
Aug 21, 2023

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Aug 18, 2023

Describe your changes:

Fixes #8885

We handle a bit better API Exceptions from the server.

  • by default, any GET call can be nullable.
  • If we get a 404 exception on a nullable call, then we just return None
  • If we get any other API exception we are now passing the exception to the client (e.g., if we find a 500).

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@pmbrull pmbrull requested a review from a team as a code owner August 18, 2023 08:59
@pmbrull pmbrull temporarily deployed to test August 18, 2023 08:59 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 18, 2023 08:59 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 18, 2023 08:59 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 18, 2023 08:59 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 18, 2023 08:59 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 18, 2023 08:59 — with GitHub Actions Inactive
@github-actions github-actions bot added documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs labels Aug 18, 2023
OnkarVO7
OnkarVO7 previously approved these changes Aug 18, 2023
@pmbrull pmbrull temporarily deployed to test August 18, 2023 12:04 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 18, 2023 12:04 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 18, 2023 12:04 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 18, 2023 12:04 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 18, 2023 12:04 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 21, 2023 08:26 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 21, 2023 08:26 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 21, 2023 08:26 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 21, 2023 08:26 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 21, 2023 08:26 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 21, 2023 08:26 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 21, 2023 08:27 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 21, 2023 08:27 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 21, 2023 08:27 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 21, 2023 08:27 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test August 21, 2023 08:27 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

[open-metadata-airflow-apis] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.6% 96.6% Coverage
0.0% 0.0% Duplication

@cypress
Copy link

cypress bot commented Aug 21, 2023

Passing run #28203 ↗︎

0 288 37 0 Flakiness 0

Details:

Add missing routes
Project: openmetadata Commit: 212fea3c3c
Status: Passed Duration: 32:44 💡
Started: Aug 21, 2023 8:50 AM Ended: Aug 21, 2023 9:23 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@pmbrull pmbrull merged commit 2f3a50e into open-metadata:main Aug 21, 2023
30 of 33 checks passed
@pmbrull pmbrull deleted the issue-8885 branch August 21, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading WARNING on logs with 404 errors
3 participants