Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ElasticSearch Test Connection & Deploy #13061

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Fix ElasticSearch Test Connection & Deploy #13061

merged 6 commits into from
Sep 8, 2023

Conversation

ulixius9
Copy link
Member

@ulixius9 ulixius9 commented Sep 1, 2023

Describe your changes:

Fix ElasticSearch Test Connection & Deploy

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues Ingestion backend safe to test Add this label to run secure Github workflows on PRs labels Sep 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
 49.42% (20780/42046) 29.61% (7475/25249) 30.41% (2357/7750)

@ulixius9 ulixius9 temporarily deployed to test September 2, 2023 18:32 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 2, 2023 18:32 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 2, 2023 18:32 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 2, 2023 18:32 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 2, 2023 18:32 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 2, 2023 18:32 — with GitHub Actions Inactive
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@ulixius9 ulixius9 temporarily deployed to test September 2, 2023 18:41 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 2, 2023 18:41 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 2, 2023 18:41 — with GitHub Actions Inactive
OnkarVO7
OnkarVO7 previously approved these changes Sep 6, 2023
View reviewed changes
@ulixius9 ulixius9 temporarily deployed to test September 8, 2023 05:19 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 8, 2023 05:19 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 8, 2023 05:19 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 8, 2023 05:19 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 8, 2023 05:19 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 8, 2023 05:19 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 8, 2023 05:19 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 8, 2023 05:19 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 8, 2023 05:19 — with GitHub Actions Inactive
@ulixius9 ulixius9 temporarily deployed to test September 8, 2023 05:19 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

[open-metadata-airflow-apis] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

37.5% 37.5% Coverage
0.0% 0.0% Duplication

@ayush-shah ayush-shah merged commit 4e63387 into main Sep 8, 2023
30 of 33 checks passed
@ayush-shah ayush-shah deleted the es_conn_deploy_fix branch September 8, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayush-shah ayush-shah ayush-shah approved these changes

@OnkarVO7 OnkarVO7 OnkarVO7 left review comments

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani chirag-madlani is a code owner

Assignees
No one assigned
Labels
backend documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulixius9 @OnkarVO7 @ayush-shah