Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7272 - BaseWorkflow docs and cleanup #13471

Merged
merged 23 commits into from
Oct 9, 2023
Merged

Fix #7272 - BaseWorkflow docs and cleanup #13471

merged 23 commits into from
Oct 9, 2023

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Oct 6, 2023

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@pmbrull pmbrull temporarily deployed to test October 6, 2023 16:29 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test October 6, 2023 16:29 — with GitHub Actions Inactive
@github-actions github-actions bot added documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs labels Oct 6, 2023
@pmbrull pmbrull temporarily deployed to test October 6, 2023 16:30 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test October 6, 2023 16:30 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

[open-metadata-airflow-apis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pmbrull pmbrull temporarily deployed to test October 8, 2023 17:48 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test October 8, 2023 17:48 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@pmbrull pmbrull temporarily deployed to test October 8, 2023 18:00 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test October 8, 2023 18:00 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test October 8, 2023 18:04 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test October 8, 2023 18:04 — with GitHub Actions Inactive
@pmbrull pmbrull marked this pull request as ready for review October 8, 2023 18:06
@pmbrull pmbrull requested a review from a team as a code owner October 8, 2023 18:06
@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

92.9% 92.9% Coverage
0.0% 0.0% Duplication

@pmbrull pmbrull merged commit f5e10c4 into open-metadata:main Oct 9, 2023
18 of 22 checks passed
@pmbrull pmbrull deleted the issue-7272-final branch October 9, 2023 05:05
@pmbrull pmbrull mentioned this pull request Oct 9, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmbrull @harshach