Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow config update for external app #14034

Merged
merged 20 commits into from
Nov 28, 2023
Merged

fix: allow config update for external app #14034

merged 20 commits into from
Nov 28, 2023

Conversation

karanh37
Copy link
Contributor

@karanh37 karanh37 commented Nov 20, 2023 •
edited by pmbrull
Loading

Describe your changes:

Allow configuration update for External Apps.

part of https://github.com/open-metadata/openmetadata-collate/issues/154

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@karanh37 karanh37 marked this pull request as draft November 20, 2023 07:17
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Nov 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 48%
 48.62% (23685/48716) 30.37% (8877/29225) 30.14% (2681/8895)

@karanh37 karanh37 closed this Nov 20, 2023
@karanh37 karanh37 reopened this Nov 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

pmbrull
pmbrull reviewed Nov 22, 2023
View reviewed changes
...spec/src/main/resources/json/schema/entity/applications/configuration/applicationConfig.json
"$ref": "internal/dataInsightsReportAppConfig.json"
},
{
"$ref": "internal/searchIndexingAppConfig.json"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

centralizing all configs

pmbrull
pmbrull reviewed Nov 22, 2023
View reviewed changes
...a-service/src/main/resources/json/data/appMarketPlaceDefinition/DataInsightsApplication.json
}
}
"allowConfiguration": false,
"appConfiguration": {}
Copy link
Collaborator

@pmbrull pmbrull Nov 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaning data insights app config and configuring it directly in the backend, since we don't allow it to be configured via the UI.

@pmbrull pmbrull marked this pull request as ready for review November 22, 2023 15:55
@pmbrull pmbrull requested a review from a team as a code owner November 22, 2023 15:55
@pmbrull pmbrull requested a review from a team as a code owner November 22, 2023 15:55
mohityadav766
mohityadav766 previously approved these changes Nov 27, 2023
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2023

[open-metadata-airflow-apis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@harshach harshach merged commit 853a83f into main Nov 28, 2023
21 checks passed
@harshach harshach deleted the fix-appConfig branch November 28, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbrull pmbrull pmbrull left review comments

@harshach harshach harshach approved these changes

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani chirag-madlani is a code owner

@mohityadav766 mohityadav766 Awaiting requested review from mohityadav766

Assignees
No one assigned
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karanh37 @harshach @pmbrull @mohityadav766