Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Data observability and notifications #14806

Merged
merged 90 commits into from
Jan 26, 2024

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Jan 20, 2024

I worked on completing the data observability alerts CRUD flow

Observability

Screen.Recording.2024-01-25.at.9.01.48.PM.mov

Notification

Screen.Recording.2024-01-25.at.9.17.03.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshach
Copy link
Collaborator

@mohityadav766 if the user selects pipeline then we shouldn't be showing "Get Schema Changes" right

Copy link

cypress bot commented Jan 26, 2024

5 failed tests on run #33061 ↗︎

5 659 25 0 Flakiness 0

Details:

Merge branch 'main' into feat-data-observability
Project: openmetadata Commit: af8a8a3c93
Status: Failed Duration: 36:06 💡
Started: Jan 26, 2024 6:56 AM Ended: Jan 26, 2024 7:32 AM
Failed  Features/ActivityFeed.spec.js • 1 failed test • cypress-ci-psql-oss-7664828109-1

View Output Video

Test Artifacts
Activity feed > Assigned task should appear to task tab Screenshots Video
Failed  Flow/Task.spec.js • 2 failed tests • cypress-ci-psql-oss-7664828109-1

View Output Video

Test Artifacts
Task flow should work > Task flow for table description Screenshots Video
Task flow should work > Task flow for table tags Screenshots Video
Failed  Pages/GlossaryVersionPage.spec.js • 1 failed test • cypress-ci-psql-oss-7664828109-1

View Output Video

Test Artifacts
Glossary and glossary term version pages should work properly > Glossary term version page should display owner and reviewer changes properly Screenshots Video
Failed  Features/RecentlyViewed.spec.js • 1 failed test • cypress-ci-psql-oss-7664828109-1

View Output Video

Test Artifacts
Recently viwed data assets > recently view section should have at max list of 5 entity Screenshots Video

Review all test suite changes for PR #14806 ↗︎

Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
13.4% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya merged commit c936ac3 into main Jan 26, 2024
20 of 25 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the feat-data-observability branch January 26, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants