New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #14786: Suggestions API #14821

Merged

harshach merged 58 commits into main from suggestions

Feb 1, 2024

Collaborator

harshach commented Jan 23, 2024 •

edited by pmbrull

Loading

Describe your changes:

Fixes #14786

I worked on ... because ...

Type of change:

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.


          Fix #14786: Suggestions API

d8f7bc2

harshach requested a review from a team as a code owner

January 23, 2024 07:02

harshach requested review from karanh37 and pmbrull

January 23, 2024 07:02

github-actions bot added backend safe to test labels


          Handle suggestions in ometa

cd11252

harshach requested a review from a team as a code owner

January 23, 2024 13:52

github-actions bot added the Ingestion label

Collaborator

pmbrull commented Jan 23, 2024 •

edited

Loading

so far I am able to add new suggestions via Python.

I think we need to delete the suggestions for a specific entity once the entity is deleted. Unit tests in python clean up the service but the db still shows older suggestions
list API giving 204

ulixius9 and others added 14 commits

January 23, 2024 23:28


          Minor: Optimise Databricks Client (#14776)

07f3a18


          MINOR - Fix SP topology context & Looker usage context (#14816)

ffbb682

* MINOR - Fix SP topology context & Looker usage context

* MINOR - Fix SP topology context & Looker usage context

* Fix tests


          Fixes #14598: Fix Tags / Labels ingestion on includeTags as False (#1…

00243ea

…4782)


          fix(ui): password error message for char limits (#14808)

9bd97c0

* fix(ui): password error message for char limits

* fix java side code


          Fixes #13556: Support for Salesforce table description ingestion (#14733

993dc56

)

* ISSUE-13556: Add suport for Salesforce table description ingestion

* ISSUE-13556: Remove unnecessary blank line

* ISSUE-13556: Fix to get description for each table

---------

Co-authored-by: Teddy <teddy.crepineau@gmail.com>


          MINOR - Better handling of Ingestion Pipeline Status (#14792)

d8555fc

* MINOR - Better handling of Ingestion Pipeline Status

* format

* format


          MINOR: Added table validation for cost analysis data (#14793)

cc00da6

* Added validation for cost analysis source

* centralized life cycle logic


          CYPRESS: simplify side navigation click in cypress (#14818)

97440f7

* simplify side navigation click in cypress

* make sidbar item uses common enum

* fix cypress failure of outside import


          fix(#14326): tier dropdown is not working in advance search (#14780)

8d61948

* improvement in advance search based on custom property

* fix a reading undefined property issue

* wip: advance search based on tier

* some code cleanup and improvement

* some fixes

* fix: ui flicker when advanceSearched is apply and refresh the page

* some cleanup

* no need to call customproperty api call, if entity not suppport customProperties

* minor change

* fix: autocomplete not working in tier search option in advance search modal

* added unit test for advance search provider component

* some cleanup

* added testcase for open modal

* added testcase for resetAllFilters method

* removed unwanted code

* added e2e test for testing tier advance search

* fix: e2e search flow for single field

* fix: string field not working after giving listValues in TierSearch

* fix: group query e2e test fix

* used asyncFetch way to get the tierOptions synchronously

* some cleanup

* remove unwanted lines

* some cleanup

* fix: selected option show option value instead of option title


          fix(minor): update skip icon for executions (#14809)

98a1448


          Fixes #14803: ignore capitalization when confirming deletes (#14804)

a6f6fff

* ignore case when confirming deletes

* Test confirmation of deletes works when case differs 

Added test case for 'delete' as the confirmation text.


          minor(config): update openmetadata-ui code reviewers (#14823)

6fa3eb4


          Add Tests

0b80504


          Add list/accept/reject apis

harshach requested review from akash-jain-10, chirag-madlani and Sachin-chaurasiya as code owners

January 24, 2024 07:28

github-actions bot added UI devops labels

Contributor

github-actions bot commented Jan 24, 2024 •

edited

Loading

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	53.31% (27518/51616)	35.2% (10951/31111)	34.11% (3222/9447)

Contributor

github-actions bot commented Jan 30, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

1 similar comment

Contributor

github-actions bot commented Jan 30, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.


          add private configs for apps

834800f

Contributor

github-actions bot commented Jan 30, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.


          fix update application icons

f151418

Contributor

github-actions bot commented Jan 30, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.


          minor center align icon

36d9ce8

Contributor

github-actions bot commented Jan 30, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.


          add private configs for apps

a9945be

Contributor

github-actions bot commented Jan 30, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

pmbrull added 5 commits

January 30, 2024 17:06


          Format

8ba8e0a


          Fix pydantic gen

95a713d


          Remove token

842623f


          Update name

b8098ee


          Rework private conf

73226a9

Contributor

github-actions bot commented Jan 31, 2024

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

pmbrull added 3 commits

January 31, 2024 15:26


          Fix apps

49ca846


          Fix apps

b3ac6b9


          Merge branch 'main' into suggestions

65b736a

Contributor

github-actions bot commented Jan 31, 2024

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

pmbrull and others added 4 commits

January 31, 2024 15:56


          Format

10414b9


          Format

d5de1e1


          Merge branch 'main' into suggestions

e7686c5


          show metapilot only if its installed

285e6a1

sonarcloud bot commented Jan 31, 2024

Quality Gate passed for 'open-metadata-airflow-apis'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Jan 31, 2024

Quality Gate passed for 'open-metadata-ui'

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Jan 31, 2024

Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
82.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pmbrull approved these changes

View reviewed changes

harshach merged commit 2e95fcb into main

23 of 24 checks passed

harshach deleted the suggestions branch

February 1, 2024 02:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pmbrull pmbrull approved these changes

karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

akash-jain-10 Awaiting requested review from akash-jain-10

chirag-madlani Awaiting requested review from chirag-madlani chirag-madlani is a code owner

Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya Sachin-chaurasiya is a code owner

Labels

backend Ingestion safe to test UI