feat(ui): support notification with new flow #14848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
safe to test
Jest test CoverageUI tests summary
|
chirag-madlani
requested review from
a team,
harshach,
karanh37 and
Sachin-chaurasiya
as code owners
chirag-madlani
merged commit c5bf898
into
feat-data-observability
16 of 18 checks passed
|
|
Sachin-chaurasiya
pushed a commit
that referenced
this pull request
Jan 26, 2024
* Centralize EventType * Format better for readability * Add Handling for Thread as Change Event * Centralize logic for Entity Message Creation * Add Thread Parent Message in Conversation * Add Task and Announcement * Support for multiple destinations * Delete existing alerts for schema changes * Delete all tables data for event subscription * Centralize logic for Notifications and Observability * Change Field Name and Remove redundant code * Test Fixes * Add more fields * Add Optional * Logical Test Case Addition Chnage Event * Add Filter By Owner * Fix Email Entity Url * added data observability settings page * localization changes for other languages * Handler closure and cleanup * complete create observibility flow * fix searchIndex method error * Update Entity Observability Filter * working observability creation * complete creation flow * fix action with arguments * fix form validations and form data formulation for 'input.actions' field * localization changes for other languages * Fixes for Data Observability * Add mention notification * Only apply mention to conversation * fIx test case * bug fixes for add and edit observability alert form functionality * fIx test case * add feature to config internal along with external destinations in alert form * Fix Formatting * Fix Url Redirection * add observability alert details page * localization changes for other languages * remove filter and action required rules * fix styling for observability form and details page * add delete functionality on observability alert details page * update view page layout and add a warning in configure destination step * localization changes for other languages * feat(ui): support notification with new flow (#14848) * feat(ui): support notification with new flow * fix notifications * add missing filters for notification alert creation flow * update the filter hiding logic to show at the start always * add check to show Actions section in observability alert creation form * code cleanup and improvements * add breadcrumb to add notification alert page * Add General Metadata Filters * remove code smells and code cleanup for add notification page * add new filter * show activity feed alert on notifications list page * add notification alert details page changes * localization changes for other languages * show icons for all the entities in the alert trigger dropdown * redirect to notification alert listing page after deleting the notification alert * change add alert page title * add logic to disable all destinations except email for users * fixed unit tests * code improvements and cleanups --------- Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com> Co-authored-by: Mohit Yadav <105265192+mohityadav766@users.noreply.github.com> Co-authored-by: Aniket Katkar <aniketkatkar97@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>