Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(#14262): Format the ES reindexing logs for better readability #14849

Merged
merged 16 commits into from
Jan 29, 2024
Merged

Fix(#14262): Format the ES reindexing logs for better readability #14849

merged 16 commits into from
Jan 29, 2024

Conversation

Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya commented Jan 24, 2024 •
edited
Loading

Describe your changes:

Fixes #14262

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Jan 24, 2024
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jan 24, 2024
@Sachin-chaurasiya Sachin-chaurasiya linked an issue Jan 24, 2024 that may be closed by this pull request
Format the ES reindexing logs for better readability #14262
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 53%
 53.24% (27299/51273) 35.22% (10876/30883) 34.07% (3195/9378)

@harshach
Copy link
Collaborator

@mohityadav766 @Sachin-chaurasiya whats the status on this?

@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as ready for review January 29, 2024 04:40
@chirag-madlani
Copy link
Collaborator

@Sachin-chaurasiya can you paste some screenshot so that we have an idea of how logs are looking now after the change?

@mohityadav766
Copy link
Contributor

@Sachin-chaurasiya can you paste some screenshot so that we have an idea of how logs are looking now after the change?

image image

@chirag-madlani @Sachin-chaurasiya

@chirag-madlani chirag-madlani added the e2e This will trigger e2e test workflows label Jan 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Jan 29, 2024

2 failed tests on run #33083 ↗︎

2 681 25 0 Flakiness 0

Details:

Merge remote-tracking branch 'origin/issue-14262' into issue-14262
Project: openmetadata Commit: 679a9fb95e
Status: Failed Duration: 37:03 💡
Started: Jan 29, 2024 5:44 AM Ended: Jan 29, 2024 6:21 AM
Failed  cypress/e2e/Pages/DataInsightSettings.spec.js • 2 failed tests • cypress-ci-psql-oss-7691602970-1

View Output Video

Test Artifacts
Data Insight settings page should work properly > Install application Screenshots Video
Data Insight settings page should work properly > Deploy & run application Screenshots Video

Review all test suite changes for PR #14849 ↗︎

@mohityadav766 mohityadav766 merged commit 8d1780c into main Jan 29, 2024
33 of 41 checks passed
@mohityadav766 mohityadav766 deleted the issue-14262 branch January 29, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

Assignees

@Sachin-chaurasiya Sachin-chaurasiya

@mohityadav766 mohityadav766

Labels
backend e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format the ES reindexing logs for better readability
4 participants
@Sachin-chaurasiya @harshach @chirag-madlani @mohityadav766