Fixes ISSUE-13473: Ensure MSSQL columns query filters to tables and views

[kchenery]

Describe your changes:

Partially Fixes ISSUE-13473

Modified the join to sys.extended_properties on MSSQL for column descriptions to make sure it only retrieves the column or table information. Previously it would pick up other related descriptions like indexes, foreign keys etc.

Type of change:

• Bug fix

Checklist:

• I have read the CONTRIBUTING document.
• My PR title is Fixes <issue-number>: <short explanation>
• I have commented on my code, particularly in hard-to-understand areas.
• For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Ive manually tested locally. I'm not sure how I could add unit/integration tests for this change

[github-actions]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

[github-actions]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

[github-actions]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

[github-actions]

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

[github-actions]

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

[github-actions]

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

[github-actions]

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

[github-actions]

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

[cypress]

175 failed tests on run #33357 ↗︎

175

554

12

5

0

Details:

Updates from running required py_format commands
Project: openmetadata	Commit: 93cee1ab85
Status: Failed	Duration: 48:28 💡
Started: Mar 7, 2024 10:52 AM	Ended: Mar 7, 2024 12:40 PM

  Pages/Entity.spec.ts • 23 failed tests • cypress-ci-mysql-pr-8186701173-1

View Output Video

Test		Artifacts
Entity detail page > Dashboard page > User as Owner assign, update & delete		Screenshots Video
Entity detail page > Dashboard page > Team as Owner assign, update & delete		Screenshots Video
Entity detail page > Dashboard page > Tags assign, update & delete		Screenshots Video
Entity detail page > Pipeline page > User as Owner assign, update & delete		Screenshots Video
Entity detail page > Pipeline page > Team as Owner assign, update & delete		Screenshots Video
Entity detail page > Pipeline page > Tags assign, update & delete		Screenshots Video
Entity detail page > Topic page > User as Owner assign, update & delete		Screenshots Video
Entity detail page > Topic page > Team as Owner assign, update & delete		Screenshots Video
Entity detail page > Topic page > Tags assign, update & delete		Screenshots Video
Entity detail page > MlModel page > User as Owner assign, update & delete		Screenshots Video
The first 10 failed tests are shown, see all 23 tests in Cypress Cloud.

  Pages/Services.spec.ts • 21 failed tests • cypress-ci-mysql-pr-8186701173-1

View Output Video

Test		Artifacts
Services detail page > Database Service page > User as Owner assign, update & delete		Screenshots Video
Services detail page > Database Service page > Team as Owner assign, update & delete		Screenshots Video
Services detail page > Database Service page > Tags assign, update & delete		Screenshots Video
Services detail page > Messaging Service page > User as Owner assign, update & delete		Screenshots Video
Services detail page > Messaging Service page > Team as Owner assign, update & delete		Screenshots Video
Services detail page > Messaging Service page > Tags assign, update & delete		Screenshots Video
Services detail page > Dashboard Service page > User as Owner assign, update & delete		Screenshots Video
Services detail page > Dashboard Service page > Team as Owner assign, update & delete		Screenshots Video
Services detail page > Dashboard Service page > Tags assign, update & delete		Screenshots Video
Services detail page > Pipeline Service page > User as Owner assign, update & delete		Screenshots Video
The first 10 failed tests are shown, see all 21 tests in Cypress Cloud.

  Pages/Database.spec.ts • 12 failed tests • cypress-ci-mysql-pr-8186701173-1

View Output Video

Test		Artifacts
Database hierarchy details page > Database page > User as Owner assign, update & delete		Screenshots Video
Database hierarchy details page > Database page > Team as Owner assign, update & delete		Screenshots Video
Database hierarchy details page > Database page > Tags assign, update & delete		Screenshots Video
Database hierarchy details page > Database Schema page > User as Owner assign, update & delete		Screenshots Video
Database hierarchy details page > Database Schema page > Team as Owner assign, update & delete		Screenshots Video
Database hierarchy details page > Database Schema page > Tags assign, update & delete		Screenshots Video
Database hierarchy details page > Table page > User as Owner assign, update & delete		Screenshots Video
Database hierarchy details page > Table page > Team as Owner assign, update & delete		Screenshots Video
Database hierarchy details page > Table page > Tags assign, update & delete		Screenshots Video
Database hierarchy details page > Store Procedure page > User as Owner assign, update & delete		Screenshots Video
The first 10 failed tests are shown, see all 12 tests in Cypress Cloud.

  Flow/SearchFlow.spec.js • 7 failed tests • cypress-ci-mysql-pr-8186701173-1

View Output Video

Test		Artifacts
Advance search > Single filed search > Verify advance search results for Service field and all condition		Screenshots Video
Advance search > Single filed search > Verify advance search results for Database field and all condition		Screenshots Video
Advance search > Single filed search > Verify advance search results for Database Schema field and all condition		Screenshots Video
Advance search > Group search > Verify Add group functionality for All with AND operator & condition == and !=		Screenshots Video
Advance search > Group search > Verify Add group functionality for All with AND operator & condition Any in and Not in		Screenshots Video
Advance search > Group search > Verify Add group functionality for All with OR operator & condition == and !=		Screenshots Video
Advance search > Group search > Verify Add group functionality for All with OR operator & condition Any in and Not in		Screenshots Video

  Pages/Glossary.spec.js • 20 failed tests • cypress-ci-mysql-pr-8186701173-1

View Output Video

Test		Artifacts
Glossary page should work properly > Create new glossary flow should work properly		Screenshots Video
Glossary page should work properly > Assign Owner		Screenshots Video
Glossary page should work properly > Update Owner		Screenshots Video
Glossary page should work properly > Remove Owner		Screenshots Video
Glossary page should work properly > Verify and Remove Tags from Glossary		Screenshots Video
Glossary page should work properly > Verify added glossary details		Screenshots Video
Glossary page should work properly > Create glossary term should work properly		Screenshots Video
Glossary page should work properly > Approval Workflow for Glossary Term		Screenshots Video
Glossary page should work properly > Updating data of glossary should work properly		Screenshots Video
Glossary page should work properly > Update glossary term		Screenshots Video
The first 10 failed tests are shown, see all 20 tests in Cypress Cloud.

The first 5 failed specs are shown, see all 30 specs in Cypress Cloud.

Review all test suite changes for PR #15433 ↗︎

[github-actions]

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

[sonarcloud]

Quality Gate passed for 'open-metadata-airflow-apis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarcloud]

Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
5.2% Duplication on New Code

See analysis details on SonarCloud