Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 16199: Check the totaVotes values for OpenSearch #16200

Conversation

heitorrbarros
Copy link

@heitorrbarros heitorrbarros commented May 9, 2024

Describe your changes:

Fixes 16199

I worked on the fix for OpenSearch 2.9 because I'm using on my organization environment. The fixes of this bug is important for us to improve the User Experience by avoiding a empty screen when the user search for somenthing.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

harshach and others added 30 commits February 27, 2024 22:05
…metadata#15349)

* supported glossary search index and fix explore glosarry count

* minor fixes and remove unused code

* fix cypress failure

(cherry picked from commit 7962524)
* Revert "add migration for MongoDB supportsProfiler = true (open-metadata#15254)"

This reverts commit ec3eb29.

* Revert "MINOR: Mongodb column profile (open-metadata#15252)"

This reverts commit 50b2709.

* Revert "MINOR: modified nosql factory to not use pymongo (open-metadata#15316)"

This reverts commit bdf2745.

* Revert "MINOR: add MongoDB sample data (open-metadata#15237)"

This reverts commit ff2ecc5.

* Revert "MINOR: add test for sqla compiler (open-metadata#15275)"

This reverts commit 4967e09.

* Revert "Fixes open-metadata#10013: Implement first stage of NoSQL profiler (open-metadata#15189)"

This reverts commit 18c22c4.

* chore: added tests back after revert
* added tooltip on floating icons

* localizaion keys

* added tooltip on tables and other icons

* clipboard copy tooltip

* fix unit test

* fix cypress issue

* code smell fix

* changes as per comments and fix cypress issue

(cherry picked from commit ec503c3)
* change placeholder for add asset in teams

* localization keys

* changes as per comment on localization key

* fix the squashing of header in entity page

(cherry picked from commit 7284bfc)
- Fix Not Authorized Token Non Present

(cherry picked from commit ce8a58c)
* doc: add whats new for 1.3.1

* Fix typos and improve Slack notifications format

* Add support for enum type in custom properties

(cherry picked from commit 0bef4ae)
)

* - Use Where clause on change event listing

* - Poll in a minute

* - Fix Entity Url
- Ignore Query Entity for Change Event Update

(cherry picked from commit 7e66756)
- Ignore Query Entity for Change Event Update
…mand (open-metadata#15444)

* open-metadata#15425 - Move SecretsManagerUpdateService to migrate command

* open-metadata#15425 - Move SecretsManagerUpdateService to migrate command
…ty (open-metadata#15449)

* Minor: filter out the filterPatterns if excludes and includes are empty

* Update limit to 20 in getTypeListByCategory

(cherry picked from commit 491aeb1)
* - Fix Poll Interval

* make poll interval as 1

* - Add random tests
- Disable Tests for Subscription for Query

* - Checkstyle Fix

* - Remove ondemand jobs as well
- On update remove already init instance

* - use alias

* - typo

* - Search Index Fix

(cherry picked from commit 9491e04)
(cherry picked from commit 7d4d7ac)
* Limit SPeL getValue to SimpleEvaluationContext

* Fix pytests

(cherry picked from commit 9a69daf)
Using OpenSearch 2.9 an exception is  raised when we try to check if a property of long type is missing with doc['field'].value != null
Copy link
Contributor

github-actions bot commented May 9, 2024

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@heitorrbarros heitorrbarros changed the title Fix function boost for opensearch Fixes 16199: Check the totaVotes values for OpenSearch May 9, 2024
@pmbrull
Copy link
Collaborator

pmbrull commented May 9, 2024

hi @heitorrbarros, I am actually having a bit of a hard time understanding what it is that you're trying to do on this PR, since it's updating most of the files.

I'll close it for now. I'd suggest to move the conversation to slack https://slack.open-metadata.org/ where we can discuss what it is that we support, why, and how to move forward.

Thanks

@pmbrull pmbrull closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error omiting all results on explore and search for any term.