FIX - Airflow tagging long names #16304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
sushi30
previously approved these changes
May 16, 2024
OnkarVO7
previously approved these changes
May 16, 2024
tutte
previously approved these changes
May 16, 2024
ayush-shah
reviewed
May 16, 2024
| @@ -255,7 +269,8 @@ def build_dag_configs(ingestion_pipeline: IngestionPipeline) -> dict: | |||
| "schedule_interval": ingestion_pipeline.airflowConfig.scheduleInterval, | |||
| "tags": [ | |||
| "OpenMetadata", | |||
| ingestion_pipeline.displayName or ingestion_pipeline.name.__root__, | |||
| clean_name_tag(ingestion_pipeline.displayName) | |||
| or clean_name_tag(ingestion_pipeline.name.__root__), | |||
| ingestion_pipeline.pipelineType.value, | |||
| ingestion_pipeline.service.name, | |||
There was a problem hiding this comment.
should we also modify service name to 100 chars?
There was a problem hiding this comment.
fair enough, hoped noone would name it that long but since we don't have a max. Good call
ayush-shah
previously approved these changes
May 16, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes failing AUTs due to test suite deployment with long names
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>