Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR - Airflow dag_tag PK #16314

Merged
merged 2 commits into from
May 17, 2024
Merged

MINOR - Airflow dag_tag PK #16314

merged 2 commits into from
May 17, 2024

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented May 16, 2024

Describe your changes:

Fixes tag clashes if name/type/service are the same

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@pmbrull pmbrull requested a review from a team May 16, 2024 17:25
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels May 16, 2024
@ShaileshParmar11 ShaileshParmar11 marked this pull request as draft May 16, 2024 18:05
@ShaileshParmar11 ShaileshParmar11 marked this pull request as ready for review May 16, 2024 18:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-airflow-apis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pmbrull pmbrull merged commit 62259a2 into open-metadata:main May 17, 2024
10 of 11 checks passed
@pmbrull pmbrull deleted the airflow-dag-tag-pk branch May 17, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OnkarVO7 OnkarVO7 OnkarVO7 approved these changes

Assignees
No one assigned
Labels
e2e:Observability Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmbrull @OnkarVO7 @ShaileshParmar11