Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: supported all_index in search index configuration form #16571

Merged
merged 12 commits into from
Jul 9, 2024
Merged

MINOR: supported all_index in search index configuration form #16571

merged 12 commits into from
Jul 9, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Jun 7, 2024 •
edited
Loading

Issue #16624

Describe your changes:

  • I worked on supporting the Hierarchy Tree for all the indexes
  • Allow all clear in the config form
  • fix the beta badge color
  • fix the checkbox color with the primary color.

Issue :
image
image

Resolved :

image image
Screen.Recording.2024-07-08.at.5.55.16.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Jun 7, 2024
@Ashish8689 Ashish8689 self-assigned this Jun 7, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jun 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 7, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
 65.4% (35991/55033) 41.76% (14147/33878) 43.88% (4381/9984)

@cypress Cypress
Copy link

cypress bot commented Jun 7, 2024 •
edited
Loading

Passing run #34570 ↗︎

0 63 8 0 Flakiness 0

Details:

fix sonar issue
Project: openmetadata Commit: 6a6aff77bc
Status: Passed Duration: 07:02 💡
Started: Jul 9, 2024 5:38 AM Ended: Jul 9, 2024 5:45 AM

Review all test suite changes for PR #16571 ↗︎

chirag-madlani
chirag-madlani reviewed Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@chirag-madlani chirag-madlani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ashish8689 I saw bit odd color for re-create index check box can you check once?
It should be primary color

...in/resources/ui/src/components/common/Form/JSONSchema/JsonSchemaWidgets/TreeSelectWidget.tsx Outdated Show resolved Hide resolved
@Ashish8689
Copy link
Contributor Author

@chirag-madlani changes made as per comments!

chirag-madlani
chirag-madlani previously approved these changes Jul 8, 2024
View reviewed changes
@Sachin-chaurasiya Sachin-chaurasiya added the e2e This will trigger e2e test workflows label Jul 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani enabled auto-merge (squash) July 9, 2024 07:16
@chirag-madlani chirag-madlani merged commit 15ae2d3 into main Jul 9, 2024
46 of 47 checks passed
@chirag-madlani chirag-madlani deleted the search-index-application branch July 9, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya left review comments

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@mohityadav766 mohityadav766 mohityadav766 approved these changes

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37 karanh37 is a code owner

Assignees

@Ashish8689 Ashish8689

Labels
backend e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ashish8689 @chirag-madlani @Sachin-chaurasiya @ShaileshParmar11 @mohityadav766