Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RbacDomain] RBAC with Domain Restrictions #16586

Merged
merged 80 commits into from
Aug 2, 2024
Merged

[RbacDomain] RBAC with Domain Restrictions #16586

merged 80 commits into from
Aug 2, 2024

Conversation

mohityadav766
Copy link
Contributor

@mohityadav766 mohityadav766 commented Jun 10, 2024

Describe your changes:

  • Added domain to all entities and createRequests
  • For Teams and User we are going to support a user/team to be part of multiple domains
  • Restrict Apis access based on domain assigned to subjectContext
  • EntityResource Listing to use domain filter
  • overrides if, listAfter() and listBefore() needs to take into account domainFilter
  • Search Listing needs to add boolTerm must for fetching results
  • Activity Feed and task listing
  • Ingestion Bot per domain

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@mohityadav766 mohityadav766 self-assigned this Jun 10, 2024
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Jun 10, 2024
Copy link

sonarcloud bot commented Aug 1, 2024

Copy link

sonarcloud bot commented Aug 1, 2024

@mohityadav766 mohityadav766 merged commit f07daae into main Aug 2, 2024
34 of 39 checks passed
@mohityadav766 mohityadav766 deleted the rbac-domain branch August 2, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend documentation Improvements or additions to documentation e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants