Fixes #16632: Add testCases property to a test suite source config
#16631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable specifying a subset of test cases to run in a test suite pipeline
github-actions
bot
added
documentation
sushi30
changed the title
testCases property to a test suite source config
TeddyCr
reviewed
Jun 12, 2024
There was a problem hiding this comment.
do we need to add an isDefault flag to this schema as well. So we can identify the default ingestion pipeline?
There was a problem hiding this comment.
null value resolves the default behavior. its documented in the description. I'd rather avoid adding this field is it has the potential for ambiguity such as:
isDefault: true
testCases: ["what_will_this_do"]There was a problem hiding this comment.
Sounds good. The behavior will be we can have multiple "default" pipelines right?
There was a problem hiding this comment.
yes. this is the same as current behavior. and as we are doing now we can enforce things on the UI side.
|
TeddyCr
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
enable specifying a subset of test cases to run in a test suite pipeline.
no schema migration is required since the default is null.
Fixes #16632
adds the
testCasesproperty to testSuitePipeline.json to enable filtering a subset of test cases to run.Type of change:
Checklist:
Fixes <issue-number>: <short explanation>