Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Pydantic fixes for redshift & kafka #16638

Merged
merged 7 commits into from
Jun 14, 2024

Conversation

ulixius9
Copy link
Member

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@ulixius9 ulixius9 requested a review from a team as a code owner June 12, 2024 19:41
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jun 12, 2024
Copy link
Contributor

@sushi30 sushi30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. it appears airflow api tests are failing after the change
  2. what was the error with kafka? is it possible to create a regression test for this?

@ulixius9
Copy link
Member Author

@sushi30 I've included tests and the airflow tests are actually not failing this is a know issue which is yet to be fixed, if you check the logs all tests actually passed

Copy link
Contributor

@sushi30 sushi30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great. since this is an integration test can you move it there?

Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-airflow-apis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 14, 2024

@ulixius9 ulixius9 merged commit e3fa340 into main Jun 14, 2024
17 of 18 checks passed
@ulixius9 ulixius9 deleted the service_ingestion_pydantic_fix branch June 14, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants