-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Pydantic fixes for redshift & kafka #16638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- it appears airflow api tests are failing after the change
- what was the error with kafka? is it possible to create a regression test for this?
@sushi30 I've included tests and the airflow tests are actually not failing this is a know issue which is yet to be fixed, if you check the logs all tests actually passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great. since this is an integration test can you move it there?
Quality Gate passed for 'open-metadata-airflow-apis'Issues Measures |
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>